Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

[Backport 5.2] sec: Make GraphQL cost limits configurable#58352

Merged
mohammadualam merged 1 commit into
5.2from
backport-58346-to-5.2
Nov 15, 2023
Merged

[Backport 5.2] sec: Make GraphQL cost limits configurable#58352
mohammadualam merged 1 commit into
5.2from
backport-58346-to-5.2

Conversation

@evict

@evict evict commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

This makes it easier for customer site-admin to change the GraphQL limits. It adds a RateLimits function to fetch the structure and makes sure we have default values.

@sourcegraph/release-guild

Test plan

CI tests, test locally.

* add ratelimit configuration to site-admin

(cherry picked from commit 8ac56ca)
@sourcegraph-bot

sourcegraph-bot commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff ae6d930...7d0fe3f.

Notify File(s)
@keegancsmith cmd/frontend/graphqlbackend/search_test.go

@evict evict force-pushed the backport-58346-to-5.2 branch from d3a7a58 to 7d0fe3f Compare November 15, 2023 20:35
@evict evict changed the title sec: Make GraphQL cost limits configurable (#58346) [Backport 5.2] sec: Make GraphQL cost limits configurable (#58346) Nov 15, 2023
@evict evict changed the title [Backport 5.2] sec: Make GraphQL cost limits configurable (#58346) [Backport 5.2] sec: Make GraphQL cost limits configurable Nov 15, 2023
@sourcegraph-bot

Copy link
Copy Markdown
Contributor

📖 Storybook live preview

@mohammadualam mohammadualam merged commit e10060c into 5.2 Nov 15, 2023
@mohammadualam mohammadualam deleted the backport-58346-to-5.2 branch November 15, 2023 21:26
@varungandhi-src varungandhi-src mentioned this pull request Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants