This repository was archived by the owner on Sep 30, 2024. It is now read-only.
code-search: handle changeset fork when creating a batch change via src-cli#58156
Merged
Conversation
Contributor
|
Good job finding this so quickly! |
vovakulikov
pushed a commit
that referenced
this pull request
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of #58150
#51572 added the
forkattribute to the changeset template. This allowed per-batch-change control for pushing to a fork of the upstream repository. However, this was only supported by SSBC, and the field was ignored by batch changes created via thesrc-clitool.This PR adds the attributes to the
/libso thatsrc-clican properly parse the fork attribute whenever it's specified in a batch spec.Test plan
ParseChangesetSpecfunction.src-cliwith the fork attribute now have the properfork_namespaceset.