This repository was archived by the owner on Sep 30, 2024. It is now read-only.
batches: add fork attribute to changeset template#51572
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 32c6d44...25df35b.
|
BolajiOlajide
approved these changes
May 26, 2023
BolajiOlajide
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me.
I haven't tested it locally, but it looks good from a code review perspective.
courier-new
reviewed
May 26, 2023
courier-new
left a comment
Contributor
There was a problem hiding this comment.
💯 Looking gooooood. Do you mind adding a CHANGELOG entry and maybe doing a comb over any of our docs related to forking/the enforceForks property to update them where appropriate?
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
courier-new
approved these changes
May 31, 2023
courier-new
left a comment
Contributor
There was a problem hiding this comment.
Yay looks great!! Just had one suggestion for the new docs change.
ErikaRS
pushed a commit
that referenced
this pull request
Jun 22, 2023
add fork attribute to changeset template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #50849
Adding fork attribute to changeset template as a boolean for now
True will force the default forking behavior of the code host" and false will force not forking the repo, overriding what is set in
batchChanges.enforceForksIf nothing is set in the batch spec but the global setting is set, then it will fall back on that behaivorIn the future we can add the ability to specify custom namespaces and fork names
Test plan
tested that a spec with the fork attribute set to true, but global enforce forks setting off will create user fork
as well as if the fork attribute in the spec is not set at all, but gloabl enforce forks it set, it will