This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[bug] Fix user permissions page with no external accounts#57372
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 3a9aff1...0d78024.
|
Contributor
eseliger
reviewed
Oct 5, 2023
eseliger
left a comment
Member
There was a problem hiding this comment.
Was the page erroring before because there was no match in the permsSourceMap or what was the problem? The fix isn't immediately obvious to me 🤔
eseliger
approved these changes
Oct 5, 2023
eseliger
left a comment
Member
There was a problem hiding this comment.
Copying in the root cause that Petri identified:
Basically, even though r.source is a pointer, it's never nil. So the resolver tried to "unmarshal" the empty string to one of the enum options, instead of setting it to null like it should be
Also, this reveals that we don't render error messages on this page at all and just keep spinning - which we should fix separately :)
sourcegraph-release-bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit 52be312)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user has had no effective permission syncs (like having no external accounts connected), the user permissions page would not work. This PR adds a case for having had no permission syncs.
Before:
After:
Test plan
Manual verification + tests should still pass.