This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.2] [bug] Fix user permissions page with no external accounts#57379
Merged
Conversation
(cherry picked from commit 52be312)
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 5775b5e...46ebb5f.
|
Contributor
keegancsmith
approved these changes
Oct 6, 2023
keegancsmith
left a comment
Member
There was a problem hiding this comment.
same as other backport PR comments, changelog section needs to be correct. Feel free to rather land all these PRs then create a new PR which fixes the changelog given doing each one is just gonna result in merge conflicts.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user has had no effective permission syncs (like having no external accounts connected), the user permissions page would not work. This PR adds a case for having had no permission syncs.
Before:
After:
Test plan
Manual verification + tests should still pass.
Backport 52be312 from #57372