Conversation
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 3a46572...989e5e8.
|
There was a problem hiding this comment.
@BolajiOlajide I also fixed this. You're correctly using protojson.Marshal on the server side to encode the response, but you also need to use protojson.Unmarshal on the client side. The normal json decoder doesn't correctly parse the response otherwise.
|
@eseliger I don't know whether or not the race detector is enabled in CI, but it never would have caught this case in the first place since we were only using one goroutine to begin with. |
Interesting, yeah 🤔 |
|
the other PR has been merged! |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.2 5.2
# Navigate to the new working tree
cd .worktrees/backport-5.2
# Create a new branch
git switch --create backport-57318-to-5.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8a30d3ca7b784367b7b2de0d38a51847ae83a5d9
# Push it to GitHub
git push --set-upstream origin backport-57318-to-5.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.2If you encouter conflict, first resolve the conflict and stage all files, then run the commands below: git cherry-pick --continue
# Push it to GitHub
git push --set-upstream origin backport-57318-to-5.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.2
|
Depends on #57316
When I run go test -race on this, I get the following (expected) race condition that @eseliger 's #57316 PR will fix.
Test plan
This is adding unit tests