This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Prevent concurrent writes to errs#57316
Merged
Merged
Conversation
This change switches to conc for the pooling, to prevent multiple go routines potentially writing to the same errs slice.
ggilmore
approved these changes
Oct 3, 2023
ggilmore
left a comment
Contributor
There was a problem hiding this comment.
Why did our race detector not see this?
Also, should this be backported?
Member
Author
Do we still run with -race in bazel? Also, not sure if this is covered in a test 🤔
I think so, but I don't think it has to be for the .0 release so we can do that EoW - WDYT? |
Contributor
|
sourcegraph-release-bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
This change switches to conc for the pooling, to prevent multiple go routines potentially writing to the same errs slice. (cherry picked from commit 8f8eff9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change switches to conc for the pooling, to prevent multiple go routines potentially writing to the same errs slice.
Test plan
Manually checked the endpoint still works.