This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Sync GitHub internal repos during user perms sync#56677
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 2193a1c...e3e5b05.
|
pjlast
commented
Sep 15, 2023
unknwon
approved these changes
Sep 15, 2023
unknwon
left a comment
Contributor
There was a problem hiding this comment.
👍 (not an authoritative approval)
mrnugget
reviewed
Sep 18, 2023
f604eb0 to
51a9fc1
Compare
eseliger
approved these changes
Oct 2, 2023
eseliger
left a comment
Member
There was a problem hiding this comment.
By no means am I an expert in the authz stuff yet, but the code change makes logical sense to me .. hope that is enough 😆
Approving, but as we talked about today, would be great to also have the toggle to disable this changed behavior.
0cffec1 to
a3b7ae8
Compare
sourcegraph-release-bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit d271395)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #56648
Sourcegraph now explicitly fetches internal repositories for organizations a user belongs to. This used to be only done when groups caching is enabled, but it leads to a lot of confusion for customers.
This may increase the number of requests made by user permission syncs. If that is the case, groups caching should be enabled.
As part of this work I decided the refactor the GitHub user permissions fetching code, which was very contrived. It's a lot easier to reason about what should be happening now.
Test plan
VCR tests updated to account for extra API calls. Local validations done as well.