This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.2] Sync GitHub internal repos during user perms sync#57386
Merged
Conversation
(cherry picked from commit d271395)
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 5775b5e...bb4ab41.
|
Contributor
keegancsmith
reviewed
Oct 6, 2023
|
|
||
| ### Added | ||
|
|
||
| - Added two new authorization configuration options to GitHub code host connections: "markInternalReposAsPublic" and "syncInternalRepoPermissions". Setting "markInternalReposAsPublic" to true is useful for organizations that have a large amount of internal repositories that everyone on the instance should be able to access, removing the need to have permissions to access these repositories. Setting "syncInternalRepoPermissions" to true adds an additional step to user permission syncs that explicitly checks for internal repositories. However, this could lead to longer user permission sync times. [#56677](https://github.com/sourcegraph/sourcegraph/pull/56677) |
Member
There was a problem hiding this comment.
@pjlast your changelog entry is not going under 5.2.1. Are you sure this was meant to be backported?
keegancsmith
approved these changes
Oct 16, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #56648
Sourcegraph now explicitly fetches internal repositories for organizations a user belongs to. This used to be only done when groups caching is enabled, but it leads to a lot of confusion for customers.
This may increase the number of requests made by user permission syncs. If that is the case, groups caching should be enabled.
As part of this work I decided the refactor the GitHub user permissions fetching code, which was very contrived. It's a lot easier to reason about what should be happening now.
Test plan
VCR tests updated to account for extra API calls. Local validations done as well.
Backport d271395 from #56677
Preview 🤩
Preview Link