This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Fuzzy finder: allow line number at the end of a filename#55064
Merged
Conversation
Previously, it was not possible to navigate straight to a specific line number with the "Files" tab of the fuzzy finder. This commit adds the ability to specify a line number with a `:NUMBER` suffix. This feature makes it possible to copy-paste error messages that use the `FILE:LINE:COLUMN` format and quickly open the location with the fuzzy finder.
Contributor
vovakulikov
reviewed
Jul 18, 2023
vovakulikov
left a comment
Contributor
There was a problem hiding this comment.
@olafurpg I am still trying to unwrap this, but I think I got your idea about having two transformers for the query and for URL (strip line and column parameters from the actual query but then use it in the URL).
The problem I have is that initially, if you try to type query:line operator in the fuzzy search on the home page, fuzzy search doesn't strip the line operator for actual query for the API call
I don't have a full understanding, but it seems like we can't ignore param argument with transformers in the FuzzyQuery.ts
protected fuzzySearch(): FuzzySearch {
return new CaseInsensitiveFuzzySearch(this.searchValues(), undefined)
}
Contributor
Author
|
@vovakulikov good catch! I only tested it with the repo-local fuzzy finder. I will fix this for the global file finder |
Previously, it only worked with the repo-local finder.
Contributor
Author
|
@vovakulikov fixed in the latest commit |
vovakulikov
approved these changes
Jul 19, 2023
vovakulikov
left a comment
Contributor
There was a problem hiding this comment.
Sorry for the slow response; thanks for the fix, and thanks for the new query operator.
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
Previously, it was not possible to navigate straight to a specific line number with the "Files" tab of the fuzzy finder. This commit adds the ability to specify a line number with a `:NUMBER` suffix. This feature makes it possible to copy-paste error messages that use the `FILE:LINE:COLUMN` format and quickly open the location with the fuzzy finder. ## Test plan - New storybook test - New unit tests for query parsing <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> (cherry picked from commit 0633c1d)
olafurpg
added a commit
that referenced
this pull request
Jul 25, 2023
BolajiOlajide
pushed a commit
that referenced
this pull request
Jul 25, 2023
BolajiOlajide
pushed a commit
that referenced
this pull request
Jul 25, 2023
…me (#55252) Previously, it was not possible to navigate straight to a specific line number with the "Files" tab of the fuzzy finder. This commit adds the ability to specify a line number with a `:NUMBER` suffix. This feature makes it possible to copy-paste error messages that use the `FILE:LINE:COLUMN` format and quickly open the location with the fuzzy finder. ## Test plan - New storybook test - New unit tests for query parsing <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> <br> Backport 0633c1d from #55064 Co-authored-by: Ólafur Páll Geirsson <olafurpg@gmail.com>
MaedahBatool
pushed a commit
that referenced
this pull request
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, it was not possible to navigate straight to a specific line number with the "Files" tab of the fuzzy finder. This commit adds the ability to specify a line number with a
:NUMBERsuffix. This feature makes it possible to copy-paste error messages that use theFILE:LINE:COLUMNformat and quickly open the location with the fuzzy finder.Test plan