This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.1] Fuzzy finder: allow line number at the end of a filename#55252
Merged
Conversation
Previously, it was not possible to navigate straight to a specific line number with the "Files" tab of the fuzzy finder. This commit adds the ability to specify a line number with a `:NUMBER` suffix. This feature makes it possible to copy-paste error messages that use the `FILE:LINE:COLUMN` format and quickly open the location with the fuzzy finder. ## Test plan - New storybook test - New unit tests for query parsing <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> (cherry picked from commit 0633c1d)
Contributor
Contributor
|
Opened PR https://github.com/sourcegraph/sourcegraph/pull/55257 to document this backport. |
Contributor
|
I manually built this branch locally to confirm that the behavior works as expected. |
Contributor
|
I approved the UI changes in chromatic. |
olafurpg
approved these changes
Jul 25, 2023
BolajiOlajide
approved these changes
Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, it was not possible to navigate straight to a specific line number with the "Files" tab of the fuzzy finder. This commit adds the ability to specify a line number with a
:NUMBERsuffix. This feature makes it possible to copy-paste error messages that use theFILE:LINE:COLUMNformat and quickly open the location with the fuzzy finder.Test plan
<!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
Backport 0633c1d from Fuzzy finder: allow line number at the end of a filename #55064