Codenotify: Notifying subscribers in CODENOTIFY files for diff a59fd1e...1efc145.

Codenotify: Notifying subscribers in OWNERS files for diff a59fd1e...1efc145.

No notifications.

@olafurpg could you test whether this branch fixes https://github.com/sourcegraph/sourcegraph/issues/50927 ?

Confirming that this https://github.com/sourcegraph/sourcegraph/issues/52132 is fixed by this PR

I'm able to reproduce the following unexpected behavior where "Implementations" and "Prototypes" show the same symbol

I ran scip snapshot on the index and there are no relationships to semanticdb maven minimized/SubClasses#abstractInterfaceMethod()., there are only implementation and reference relationships from that symbol

To reproduce, open URL https://sourcegraph.test:3443/github.com/sourcegraph/scip-java@a6a169f3012131c4b4b7242f1e72982fee669a48/-/blob/tests/minimized/src/main/java/minimized/SubClasses.java?L6:17-6:39#tab=implementations_java

I built the index with scip-java index --build-tool=sbt --index-semanticdb.emit-inverse-relationships=false using scip-java 0.8.25

I can reproduce the same behavior with scip-typescript in the sourcegraph/sourcegraph repository at the URL https://sourcegraph.test:3443/github.com/sourcegraph/sourcegraph@de6aeb8b9f3092a9b5c205e169e5ca1e9ca577a2/-/blob/client/web/src/fuzzyFinder/CaseInsensitiveFuzzySearch.ts?L32:12-32:18#tab=implementations_typescript

I suspect the underlying reason is because these symbols have is_reference and is_implementation relationships because I can only reproduce it for method symbols (not classes)

@olafurpg Pushed a fix to implementations - can you take another look?

@efritz I can confirm the issue I reported has been fixed. I ran a few more tests and didn't identify any surprising behavior. This PR is a huge improvement. Thank you for fixing this! 🙏🏻

Hmm, I'm not having success with this PR with commit b9bfe15. With this PR:

On Sourcegraph.com below:

The correct result should be 100+ implementations (subclasses) and 0 prototypes (superclasses)

Index information:

   repo: github.com/llvm/llvm-project
   commit: 867f2d9e5c9a736eb97fe5a51aa2850abfd02a96
   root: .
   file: 3.scip
   indexer: scip-clang
   indexerVersion: 0.2.3

Compressed index file: https://drive.google.com/file/d/16j76Qiigsb_mZ5u4s4Bd-XoFP4412B92/view?usp=sharing

Also, can you perhaps tweak the PR title and/or the information in the description? Right now, as it stands, it's very non-obvious that this PR is meant to fix a bunch of bugs related to Find Implementations.

@varungandhi-src Running locally I got this:

🤔🤔🤔

@efritz Along with the index uploaded earlier, also upload this index at an older commit: https://drive.google.com/file/d/1EtLCtzPw3ur95BpQ2sfjpfIGA3wI8AHp/view?usp=sharing

Invocation:

src code-intel upload -repo=github.com/llvm/llvm-project -commit=e0f3110b854a476c16cce7b44472cd7838d344e9 -root=. -file=2.scip

It looks like the implementations at the newer commit (867f2d9e5c9a736eb97fe5a51aa2850abfd02a96) go missing when both indexes are present. If I delete the index for e0f3110b854a476c16cce7b44472cd7838d344e9, I'm able to reproduce what you're seeing.

The backport to 5.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.1 5.1
# Navigate to the new working tree
cd .worktrees/backport-5.1
# Create a new branch
git switch --create backport-54410-to-5.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0889c891dbb49f176e5f8f51c832a91dabfbd95d
# Push it to GitHub
git push --set-upstream origin backport-54410-to-5.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.1

Then, create a pull request where the base branch is 5.1 and the compare/head branch is backport-54410-to-5.1.