Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

codenav: Refactor common navigation queries#53710

Merged
efritz merged 2 commits into
mainfrom
ef/codenav-wip
Jun 28, 2023
Merged

codenav: Refactor common navigation queries#53710
efritz merged 2 commits into
mainfrom
ef/codenav-wip

Conversation

@efritz

@efritz efritz commented Jun 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Refactor main definition, reference, prototype, and implementation functions from the service level down.

Test plan

Local testing, updated unit tests.

@cla-bot cla-bot Bot added the cla-signed label Jun 19, 2023
@efritz efritz force-pushed the ef/codenav-wip branch 2 times, most recently from 1f2b69e to e58ccb8 Compare June 19, 2023 21:30
@efritz efritz mentioned this pull request Jun 20, 2023
Closed
@efritz efritz force-pushed the ef/codenav-wip branch 3 times, most recently from 18c4d55 to 167f96c Compare June 21, 2023 22:13
@efritz efritz self-assigned this Jun 22, 2023
@efritz efritz added team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) team/language-platform labels Jun 22, 2023
@efritz efritz marked this pull request as ready for review June 27, 2023 18:23
@sourcegraph-bot

sourcegraph-bot commented Jun 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff d19f0e7...61e454f.

Notify File(s)
@Strum355 enterprise/internal/codeintel/codenav/BUILD.bazel
enterprise/internal/codeintel/codenav/internal/lsifstore/locations_by_position.go
enterprise/internal/codeintel/codenav/internal/lsifstore/locations_by_position_test.go
enterprise/internal/codeintel/codenav/internal/lsifstore/scan.go
enterprise/internal/codeintel/codenav/internal/lsifstore/store.go
enterprise/internal/codeintel/codenav/mocks_test.go
enterprise/internal/codeintel/codenav/observability.go
enterprise/internal/codeintel/codenav/service_new.go
enterprise/internal/codeintel/codenav/service_new_test.go
enterprise/internal/codeintel/codenav/types.go

@efritz efritz requested review from Strum355 and cesrjimenez June 27, 2023 19:05
@efritz efritz mentioned this pull request Jun 28, 2023
Merged
@efritz efritz merged commit 26c798e into main Jun 28, 2023
@efritz efritz deleted the ef/codenav-wip branch June 28, 2023 23:16
@github-actions github-actions Bot mentioned this pull request Jun 28, 2023
Merged
github-actions Bot pushed a commit that referenced this pull request Jun 28, 2023
@efritz @github-actions
codenav: Refactor common navigation queries (#53710)
efac50f 
(cherry picked from commit 26c798e)
coury-clark pushed a commit that referenced this pull request Jul 5, 2023
@github-actions @efritz
[Backport 5.1] codenav: Refactor common navigation queries (#54412)
af6300b 
Refactor main definition, reference, prototype, and implementation
functions from the service level down.

## Test plan

Local testing, updated unit tests. <br> Backport
26c798e from #53710

Co-authored-by: Eric Fritz <eric@sourcegraph.com>
@efritz efritz mentioned this pull request Jul 7, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Strum355 Strum355 Awaiting requested review from Strum355

1 more reviewer

@cesrjimenez cesrjimenez cesrjimenez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@efritz efritz

Labels

cla-signed team/graph Graph Team (previously Code Intel/Language Tools/Language Platform)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efritz @sourcegraph-bot @cesrjimenez