client/web: Use perforce cid in tree URL#54051
Conversation
|
Found another place where this needs to be updated. Adding that code. Please hold onto the reviews till then. |
sashaostrikov
left a comment
There was a problem hiding this comment.
LGTM! One import needs to be fixed :)
| import { Timestamp } from '@sourcegraph/branded/src/components/Timestamp' | ||
| import { pluralize } from '@sourcegraph/common' | ||
| import { Button, ButtonGroup, Link, Icon, Code, screenReaderAnnounce, Tooltip } from '@sourcegraph/wildcard' | ||
| import { Button, ButtonGroup, Link, Icon, Code, screenReaderAnnounce, Tooltip, ErrorAlert } from '@sourcegraph/wildcard' |
There was a problem hiding this comment.
I guess the linter will fail otherwise
| import { Button, ButtonGroup, Link, Icon, Code, screenReaderAnnounce, Tooltip, ErrorAlert } from '@sourcegraph/wildcard' | |
| import { Button, ButtonGroup, ErrorAlert, Link, Icon, Code, screenReaderAnnounce, Tooltip } from '@sourcegraph/wildcard' |
There was a problem hiding this comment.
Hmm, vscode added that and the linter didn't fail. 🤔
Is that enforced usually?
There was a problem hiding this comment.
Maybe it's not enforced and the linter won't fail, we just usually them in an alphabetic order.
Ah, the linter would've failed if the import statements themselves (e.g. import lines) were out of alphabetic order.
Sorry for confusion!
There was a problem hiding this comment.
No worries - I prefer them in the alphabetical order too. Thanks for the call out!
- Also make a utility func to check the experimental flag And address reviews comments: - Remove margin - Fix import
Links to "Browse files @CID" will now directly go to the URL pointing to the CID instead of the Commit SHA. ## Test plan - Tested manually - Builds should pass <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> <br> Backport 0116fb6 from #54051 Co-authored-by: Indradhanush Gupta <indradhanush.gupta@gmail.com>
Links to "Browse files @CID" will now directly go to the URL pointing to the CID instead of the Commit SHA.
Test plan