This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.1] client/web: Use perforce cid in tree URL#54121
Merged
Conversation
indradhanush
approved these changes
Jun 26, 2023
27 tasks
Contributor
Member
|
@indradhanush build is failling |
Contributor
|
@keegancsmith Rebuilt without cache and it passed. :D |
peterguy
reviewed
Jun 26, 2023
| const revisionType = | ||
| window.context.experimentalFeatures.perforceChangelistMapping === 'enabled' && | ||
| node?.sourceType === RepositoryType.PERFORCE_DEPOT | ||
| isPerforceChangelistMappingEnabled() && node?.sourceType === RepositoryType.PERFORCE_DEPOT |
Contributor
There was a problem hiding this comment.
Can we use isPerforceDepotSource(node?.sourceType) here?
Contributor
There was a problem hiding this comment.
Makes sense. I'll fix this in main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links to "Browse files @CID" will now directly go to the URL pointing to the CID instead of the Commit SHA.
Test plan
<!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
Backport 0116fb6 from #54051