This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[fix] fixes for mau calculations in product analytics#52581
Merged
Conversation
This is for usage analytics in the product. Previously we were filtering out the backend events, but as part of #52306 this was removed, because I believed it shold not be there, as it was not part of the BuildCommonUsageConds in the event_logs. However event_logs also add this condition directly in the query string, which I did not notice.
sashaostrikov
approved these changes
May 30, 2023
This was wrong when current time was 2023-04-30T23:59:00Z, because the resulting from timestamp was calculated as 2023-03-01T00:00:00Z whereas user (and me) would expect 2023-02-01T00:00:00Z. Fixed by first truncating the current date and then subtracting the months. Extracted into it's own funciton for easier unit tests.
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.0 5.0
# Navigate to the new working tree
cd .worktrees/backport-5.0
# Create a new branch
git switch --create backport-52581-to-5.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ee6e66ee50eb1e0ffffcdfc80d170d8160283cf5
# Push it to GitHub
git push --set-upstream origin backport-52581-to-5.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.0Then, create a pull request where the |
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.0 5.0
# Navigate to the new working tree
cd .worktrees/backport-5.0
# Create a new branch
git switch --create backport-52581-to-5.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ee6e66ee50eb1e0ffffcdfc80d170d8160283cf5
# Push it to GitHub
git push --set-upstream origin backport-52581-to-5.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.0Then, create a pull request where the |
kopancek
added a commit
that referenced
this pull request
May 31, 2023
Fixes MAU calculation in usage analytics in the product. Previously we were filtering out the backend events, but as part of was not part of the BuildCommonUsageConds in the event_logs. However event_logs also add this condition directly in the query string, which I did not notice. Also, our timestamp calculation suffered from an edge case, where the from time was not calculated right, e.g. on dates like `2023-04-30T23:59:00Z`. Tested locally and with customer data + added unit tests. (cherry picked from commit ee6e66e)
keegancsmith
pushed a commit
that referenced
this pull request
May 31, 2023
ErikaRS
pushed a commit
that referenced
this pull request
Jun 22, 2023
Fixes MAU calculation in usage analytics in the product. Previously we were filtering out the backend events, but as part of #52306 this was removed, because I believed it shold not be there, as it was not part of the BuildCommonUsageConds in the event_logs. However event_logs also add this condition directly in the query string, which I did not notice. Also, our timestamp calculation suffered from an edge case, where the from time was not calculated right, e.g. on dates like `2023-04-30T23:59:00Z`. ## Test plan Tested locally and with customer data + added unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MAU calculation in usage analytics in the product.
Previously we were filtering out the backend events, but as part of #52306 this was removed, because I believed it shold not be there, as it was not part of the BuildCommonUsageConds in the event_logs. However event_logs also add this condition directly in the query string, which I did not notice.
Also, our timestamp calculation suffered from an edge case, where the from time was not calculated right, e.g. on dates like
2023-04-30T23:59:00Z.Test plan
Tested locally and with customer data + added unit tests.