Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

[Backport-5.0] [fix] fixes for mau calculations in product analytics (#52581)#52682

Merged
keegancsmith merged 1 commit into
5.0from
backport-52581-to-5.0
May 31, 2023
Merged

[Backport-5.0] [fix] fixes for mau calculations in product analytics (#52581)#52682
keegancsmith merged 1 commit into
5.0from
backport-52581-to-5.0

Conversation

@kopancek

Copy link
Copy Markdown
Contributor

Fixes MAU calculation in usage analytics in the product.

Previously we were filtering out the backend events, but as part of
was not part of the BuildCommonUsageConds in the event_logs. However
event_logs also add this condition directly in the query string, which I
did not notice.

Also, our timestamp calculation suffered from an edge case, where the
from time was not calculated right, e.g. on dates like
`2023-04-30T23:59:00Z`.

Tested locally and with customer data + added unit tests.

(cherry picked from commit ee6e66e)
@kopancek kopancek requested a review from a team May 31, 2023 08:59
@kopancek kopancek self-assigned this May 31, 2023
@cla-bot cla-bot Bot added the cla-signed label May 31, 2023
@keegancsmith keegancsmith enabled auto-merge (squash) May 31, 2023 09:04
@keegancsmith keegancsmith merged commit 00d83fe into 5.0 May 31, 2023
@keegancsmith keegancsmith deleted the backport-52581-to-5.0 branch May 31, 2023 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants