Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Expose new domain property on github_app nodes#52269

Merged
st0nebreaker merged 5 commits into
batches/commit-signingfrom
bb/add_domain_types_to_gh_app
May 23, 2023
Merged

Expose new domain property on github_app nodes#52269
st0nebreaker merged 5 commits into
batches/commit-signingfrom
bb/add_domain_types_to_gh_app

Conversation

@st0nebreaker

@st0nebreaker st0nebreaker commented May 22, 2023 •
edited by BolajiOlajide
Loading

Copy link
Copy Markdown
Contributor

Closes #52270
Exposes new domain property from #52268

Test plan

  • Make sure there is a GitHub App on your instance
  • In the API Console ensure the following query doesn't fail and returns the domain property:
query {
  gitHubApps {
    nodes {
      name
      domain
    }
  }
}

@cla-bot cla-bot Bot added the cla-signed label May 22, 2023
@st0nebreaker st0nebreaker force-pushed the bb/add_domain_types_to_gh_app branch from 68fe68e to 938700c Compare May 22, 2023 17:24
@st0nebreaker st0nebreaker requested review from a team and kopancek May 22, 2023 17:27
kopancek
kopancek approved these changes May 23, 2023
View reviewed changes
Comment thread cmd/frontend/graphqlbackend/githubapps.graphql Outdated
@st0nebreaker st0nebreaker marked this pull request as ready for review May 23, 2023 15:47
@sourcegraph-bot

sourcegraph-bot commented May 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 48291ea...d0f8c30.

Notify File(s)
@unknwon enterprise/cmd/frontend/internal/auth/githubappauth/resolver.go

@sourcegraph-bot

sourcegraph-bot commented May 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

📖 Storybook live preview

@BolajiOlajide BolajiOlajide force-pushed the bb/add_domain_types_to_gh_app branch from c69c1ec to 7548296 Compare May 23, 2023 17:18
@st0nebreaker st0nebreaker force-pushed the batches/commit-signing branch from c1dd3ea to 40870a1 Compare May 23, 2023 18:06
@st0nebreaker st0nebreaker force-pushed the bb/add_domain_types_to_gh_app branch from 7548296 to 45e0b92 Compare May 23, 2023 18:07
courier-new
courier-new approved these changes May 23, 2023
View reviewed changes

@courier-new courier-new left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving these bite-size atomic PRs. 😁

Comment thread cmd/frontend/graphqlbackend/githubapps.graphql Outdated
st0nebreaker and others added 5 commits May 23, 2023 20:24
@BolajiOlajide BolajiOlajide force-pushed the bb/add_domain_types_to_gh_app branch from 021c7c7 to d0f8c30 Compare May 23, 2023 19:24
@st0nebreaker st0nebreaker merged commit 14b81ad into batches/commit-signing May 23, 2023
@st0nebreaker st0nebreaker deleted the bb/add_domain_types_to_gh_app branch May 23, 2023 20:16
BolajiOlajide added a commit that referenced this pull request May 26, 2023
@st0nebreaker @kopancek
@BolajiOlajide @courier-new
Expose new domain property on github_app nodes (#52269)
4f2c6d8 
Closes #52270
Exposes new `domain` property from #52268

## Test plan
- Make sure there is a GitHub App on your instance
- In the API Console ensure the following query doesn't fail and returns
the `domain` property:
```
query {
  gitHubApps {
    nodes {
      name
      domain
    }
  }
}
````

---------

Co-authored-by: Milan Freml <kopancek@users.noreply.github.com>
Co-authored-by: Bolaji Olajide <25608335+BolajiOlajide@users.noreply.github.com>
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@BolajiOlajide BolajiOlajide BolajiOlajide left review comments

@courier-new courier-new courier-new approved these changes

@kopancek kopancek kopancek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BolajiOlajide BolajiOlajide

@st0nebreaker st0nebreaker

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@st0nebreaker @sourcegraph-bot @courier-new @kopancek @BolajiOlajide