This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Adds domain column to github_apps migration#52268
Merged
st0nebreaker merged 5 commits intoMay 23, 2023
Merged
Conversation
eseliger
approved these changes
May 22, 2023
31 tasks
kopancek
approved these changes
May 23, 2023
Co-authored-by: Milan Freml <kopancek@users.noreply.github.com>
Co-authored-by: Milan Freml <kopancek@users.noreply.github.com>
st0nebreaker
added a commit
that referenced
this pull request
May 23, 2023
Closes #52270 Exposes new `domain` property from #52268 ## Test plan - Make sure there is a GitHub App on your instance - In the API Console ensure the following query doesn't fail and returns the `domain` property: ``` query { gitHubApps { nodes { name domain } } } ```` --------- Co-authored-by: Milan Freml <kopancek@users.noreply.github.com> Co-authored-by: Bolaji Olajide <25608335+BolajiOlajide@users.noreply.github.com> Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
BolajiOlajide
added a commit
that referenced
this pull request
May 26, 2023
Closes #52270 Exposes new `domain` property from #52268 ## Test plan - Make sure there is a GitHub App on your instance - In the API Console ensure the following query doesn't fail and returns the `domain` property: ``` query { gitHubApps { nodes { name domain } } } ```` --------- Co-authored-by: Milan Freml <kopancek@users.noreply.github.com> Co-authored-by: Bolaji Olajide <25608335+BolajiOlajide@users.noreply.github.com> Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new
domaincolumn to the github_apps table to close #52264@kopancek - What default value do you want for this field for your use case? We will change the column to
batchesfor Batch Changes GitHub Apps. We set the default value toreposfor now, let us know what you think! 🙏🏻Test plan
sg migration upensure newdomaincolumn togithub_appstablesg migration undonew column is removed