This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Gate Batch Change UI based on license#52113
Merged
Merged
Conversation
st0nebreaker
commented
May 17, 2023
Collaborator
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 1bba6c5 and 055019e or learn more. Open explanation
|
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 0294b63...1bba6c5.
|
Contributor
courier-new
reviewed
May 19, 2023
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
Contributor
|
Looks great! I think there might just be a couple tests and Storybook stories we need to update to include this extra window context so that they continue to capture the same scenario. You can view the Buildkite failure and Chromatic diff to see which tests/stories need the added context. I think you should just be able to write to |
c6a6c60 to
55e019b
Compare
55e019b to
46c6c9a
Compare
courier-new
reviewed
May 23, 2023
…ry.tsx Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
courier-new
reviewed
May 24, 2023
62add46 to
383a2a0
Compare
courier-new
approved these changes
May 25, 2023
courier-new
left a comment
Contributor
There was a problem hiding this comment.
Thank you for so patiently working through all this with me! 🙌
courier-new
reviewed
May 25, 2023
161d91f to
b470f33
Compare
2bc93c7 to
1bba6c5
Compare
ErikaRS
pushed a commit
that referenced
this pull request
Jun 22, 2023
Closes #49714 - Uses new batch change licensing info exposed on the JS Context (from #52044) - Hides Batch Change nav item on OSS - Shows Get Started page for dotcom & enterprise customers without a Batch Changes license ## Test plan - Run `sg start oss` - observe missing batch changes nav item (route is inaccessible too) - Run `sg start dotcom` - observe batch changes page, only the `Get started` content displays (subrotues are inaccessible) - Mock enterprise with limited batch changes - observe limited batch change warning once executing a SSBC --------- Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49714
LicenseInfo#52044)Test plan
sg start oss- observe missing batch changes nav item (route is inaccessible too)sg start dotcom- observe batch changes page, only theGet startedcontent displays (subrotues are inaccessible)