This repository was archived by the owner on Sep 30, 2024. It is now read-only.
httptrace: do not mutate shared logger#51826
Merged
Merged
Conversation
eseliger
approved these changes
May 11, 2023
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff d39cf9f...ad1bb70.
|
keegancsmith
approved these changes
May 11, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.0 5.0
# Navigate to the new working tree
cd .worktrees/backport-5.0
# Create a new branch
git switch --create backport-51826-to-5.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ce842515c0a800aea314ef27437d7dfdb2bee79c
# Push it to GitHub
git push --set-upstream origin backport-51826-to-5.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.0Then, create a pull request where the |
bobheadxi
added a commit
that referenced
this pull request
May 11, 2023
Previously, every slow request would be logged with the first trace ID that the middleware encounters. This change ensures we make a copy of the base logger first before creating new loggers with additional fields. Detected by @michaellzc who noticed all slow requests were being logged with the same executor request, even when they weren't :) ## Test plan n/a (cherry picked from commit ce84251)
cesrjimenez
pushed a commit
that referenced
this pull request
May 17, 2023
Previously, every slow request would be logged with the first trace ID that the middleware encounters. This change ensures we make a copy of the base logger first before creating new loggers with additional fields. Detected by @michaellzc who noticed all slow requests were being logged with the same executor request, even when they weren't :) ## Test plan n/a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, every slow request would be logged with the first trace ID that the middleware encounters. This change ensures we make a copy of the base logger first before creating new loggers with additional fields.
Detected by @michaellzc who noticed all slow requests were being logged with the same executor request, even when they weren't :)
Test plan
n/a