This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Backport #51826 to 5.0#51835
Merged
Merged
Conversation
Previously, every slow request would be logged with the first trace ID that the middleware encounters. This change ensures we make a copy of the base logger first before creating new loggers with additional fields. Detected by @michaellzc who noticed all slow requests were being logged with the same executor request, even when they weren't :) ## Test plan n/a (cherry picked from commit ce84251)
michaellzc
approved these changes
May 11, 2023
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 4e2c1351864ac743068e7b3afbc94b71030cc71b...801ac70a7e4e948c7a518dcb42140e6ad16360d9.
|
f3f730c to
801ac70
Compare
801ac70 to
22d6df5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, every slow request would be logged with the first trace ID that the middleware encounters. This change ensures we make a copy of the base logger first before creating new loggers with additional fields.
See #51826
Test plan
n/a
(cherry picked from commit ce84251)