This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat: allow disabling of user centric or repo centric permission sync#51255
Merged
Merged
Conversation
This is beneficial in cases where one or the other is clearly much faster. It is also beneficial in cases when we have a clash between user centric and repo centric permission sync.
vdavid
approved these changes
Apr 28, 2023
vdavid
left a comment
Contributor
There was a problem hiding this comment.
Makes sense and is definitely backward-compatible. The code LGTM. Thanks for the nicely structured tests!
sashaostrikov
approved these changes
Apr 28, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.0 5.0
# Navigate to the new working tree
cd .worktrees/backport-5.0
# Create a new branch
git switch --create backport-51255-to-5.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cec1bee34e42249243080192f593039b3ca0db04
# Push it to GitHub
git push --set-upstream origin backport-51255-to-5.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.0Then, create a pull request where the |
kopancek
added a commit
that referenced
this pull request
Apr 28, 2023
kopancek
added a commit
that referenced
this pull request
Apr 28, 2023
## Test plan No test, only changelog change
kopancek
added a commit
that referenced
this pull request
May 4, 2023
…permission sync (#51255) This is beneficial in cases where one or the other is clearly much faster. It is also beneficial in cases when we have a clash between user centric and repo centric permission sync. It's basically just a site config schema change. Tested locally + unit tests. (cherry picked from commit cec1bee)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is beneficial in cases where one or the other is clearly much faster. It is also beneficial in cases when we have a clash between user centric and repo centric permission sync.
Test plan
It's basically just a site config schema change. Tested locally + unit tests.