Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

[Backport 5.0] feat: allow disabling of user centric or repo centric permission sync#51454

Merged
unknwon merged 1 commit into
5.0from
backport-51255-to-5.0
May 4, 2023
Merged

[Backport 5.0] feat: allow disabling of user centric or repo centric permission sync#51454
unknwon merged 1 commit into
5.0from
backport-51255-to-5.0

Conversation

@kopancek

@kopancek kopancek commented May 4, 2023

Copy link
Copy Markdown
Contributor

backport of #51255

Test plan

just a site config schema change, tested locally

@kopancek kopancek requested a review from pjlast May 4, 2023 08:44
@cla-bot cla-bot Bot added the cla-signed label May 4, 2023
@kopancek kopancek changed the title feat: allow disabling of user centric or repo centric permission sync… [Backport 5.0] feat: allow disabling of user centric or repo centric permission sync May 4, 2023
@kopancek kopancek force-pushed the backport-51255-to-5.0 branch from 2ada4a9 to 3834d73 Compare May 4, 2023 09:26
…permission sync (#51255)

This is beneficial in cases where one or the other is clearly much
faster. It is also beneficial in cases when we have a clash between user
centric and repo centric permission sync.

It's basically just a site config schema change. Tested locally + unit
tests.

(cherry picked from commit cec1bee)
@kopancek kopancek force-pushed the backport-51255-to-5.0 branch from 3834d73 to 8d0e03e Compare May 4, 2023 09:26
@sourcegraph-bot

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff e3f03f2...8d0e03e.

Notify File(s)
@indradhanush enterprise/cmd/repo-updater/internal/authz/perms_syncer.go
@unknwon enterprise/cmd/repo-updater/internal/authz/perms_syncer.go

@kopancek kopancek requested a review from a team May 4, 2023 09:34

@sashaostrikov sashaostrikov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kopancek kopancek self-assigned this May 4, 2023
@unknwon unknwon merged commit 216cceb into 5.0 May 4, 2023
@unknwon unknwon deleted the backport-51255-to-5.0 branch May 4, 2023 11:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants