Reintroduce ordering of auth providers#50586
Conversation
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 4250b89 and c9ddb0d or learn more. Open explanation
|
vdavid
left a comment
There was a problem hiding this comment.
Nice! I only looked at the second commit (the fix) as the rest was already reviewed. Makes sense, and thanks for the thorough testing!
|
Previous main-dry-run failed, so I added some more changes and more unit tests to make sure this time it will succeed. |
|
This is one of a few PRs where the SonarCloud Code Analysis check is stuck on "Expected — Waiting for status to be reported". Seems to be a problem on either the github or sonarcloud end as the check passed. Hopefully it's a transient issue and will fix itself if the checks are rerun (pushing a new commit or rerunning them manually), but let me know if not. |
92c01c7 to
4250b89
Compare
|
Force pushed a small change to the last commit message to see if it would help |
## Description This PR reintroduces the changes that were reverted in - #50450 Also fixes a problem where I did not handle correctly the case when certain fields have zero value. ## Test plan - [x] New unit test added for the fixed changes. - [x] [main-dry-run can be seen here](https://buildkite.com/sourcegraph/sourcegraph/builds/213015)
## Description This PR reintroduces the changes that were reverted in - #50450 Also fixes a problem where I did not handle correctly the case when certain fields have zero value. ## Test plan - [x] New unit test added for the fixed changes. - [x] [main-dry-run can be seen here](https://buildkite.com/sourcegraph/sourcegraph/builds/213015)
Description
This PR reintroduces the changes that were reverted in
Also fixes a problem where I did not handle correctly the case when certain fields have zero value.
Test plan