This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Revert "feat: add ordering to auth providers in login screen"#50450
Merged
Conversation
kopancek
approved these changes
Apr 6, 2023
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 6458121 and 4c2117b or learn more. Open explanation
|
b5faa50 to
6458121
Compare
…" [no-bazel] This reverts commit 2229942.
6458121 to
d47f709
Compare
0xnmn
approved these changes
Apr 7, 2023
almeidapaulooliveira
pushed a commit
that referenced
this pull request
Apr 8, 2023
Reverts sourcegraph/sourcegraph#50434 Test Plan: CI tests
2 tasks
kopancek
added a commit
that referenced
this pull request
Apr 13, 2023
## Description This PR reintroduces the changes that were reverted in - #50450 Also fixes a problem where I did not handle correctly the case when certain fields have zero value. ## Test plan - [x] New unit test added for the fixed changes. - [x] [main-dry-run can be seen here](https://buildkite.com/sourcegraph/sourcegraph/builds/213015)
almeidapaulooliveira
pushed a commit
that referenced
this pull request
Apr 13, 2023
## Description This PR reintroduces the changes that were reverted in - #50450 Also fixes a problem where I did not handle correctly the case when certain fields have zero value. ## Test plan - [x] New unit test added for the fixed changes. - [x] [main-dry-run can be seen here](https://buildkite.com/sourcegraph/sourcegraph/builds/213015)
cesrjimenez
pushed a commit
that referenced
this pull request
Apr 14, 2023
## Description This PR reintroduces the changes that were reverted in - #50450 Also fixes a problem where I did not handle correctly the case when certain fields have zero value. ## Test plan - [x] New unit test added for the fixed changes. - [x] [main-dry-run can be seen here](https://buildkite.com/sourcegraph/sourcegraph/builds/213015)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts sourcegraph/sourcegraph#50434
Test Plan: CI tests