This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[chore] hide cursor and bracket match in read-only code host config#49682
Merged
Conversation
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits d31c49b and 5875e18 or learn more. Open explanation
|
mrnugget
approved these changes
Mar 20, 2023
mrnugget
left a comment
Contributor
There was a problem hiding this comment.
OMG! Thank you so much!!
sashaostrikov
approved these changes
Mar 20, 2023
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
…49682) ## Video https://www.loom.com/share/65d920b3a1c54ae8b17d5eb8bc38a9c9 ## Test plan CSS change only. Tested locally, works as shown on the video above. ## App preview: - [Web](https://sg-web-milan-ronly-code-host-config.onrender.com/search) Check out the [client app preview documentation](https://docs.sourcegraph.com/dev/how-to/client_pr_previews) to learn more. (cherry picked from commit 6cef2d4)
kopancek
added a commit
that referenced
this pull request
Mar 20, 2023
…e host config (#49693) ## Video https://www.loom.com/share/65d920b3a1c54ae8b17d5eb8bc38a9c9 ## Test plan CSS change only. Tested locally, works as shown on the video above. ## App preview: - [Web](https://sg-web-milan-ronly-code-host-config.onrender.com/search) Check out the [client app preview documentation](https://docs.sourcegraph.com/dev/how-to/client_pr_previews) to learn more. <br> Backport 6cef2d4 from #49682 Co-authored-by: Milan Freml <kopancek@users.noreply.github.com> Co-authored-by: Milan Freml <milan.freml@sourcegraph.com>
fkling
added a commit
that referenced
this pull request
Jun 13, 2024
PR #49682 made some CSS changes to hide the caret as well as bracket matching for this input. I assume that seeing those in a read-only input was confusing. However, hiding the textarea element also breaks copying the input's value. Instead of hiding the textarea, we are now hiding the visiual representation of the caret. A noteable difference in behavior now is that it's possible to focus the input via tab, but there is no visual indiciation that the editor has focus (since we hide the caret, as before).
fkling
added a commit
that referenced
this pull request
Jun 13, 2024
…63239) PR #49682 made some CSS changes to hide the caret as well as bracket matching for this input. I assume that seeing those in a read-only input was confusing. However, hiding the textarea element also breaks copying the input's value. Instead of hiding the textarea, we are now hiding the visiual representation of the caret. A noteable difference in behavior now is that it's possible to focus the input via tab, but there is no visual indiciation that the editor has focus (since we hide the caret, as before). ## Test plan Manual tested on https://sourcegraph.test:3443/site-admin/external-services/RXh0ZXJuYWxTZXJ2aWNlOjky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video
https://www.loom.com/share/65d920b3a1c54ae8b17d5eb8bc38a9c9
Test plan
CSS change only. Tested locally, works as shown on the video above.
App preview:
Check out the client app preview documentation to learn more.