This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(search): Copy text from read-only code host configuration input#63239
Merged
fkling merged 1 commit intoJun 13, 2024
Merged
Conversation
PR #49682 made some CSS changes to hide the caret as well as bracket matching for this input. I assume that seeing those in a read-only input was confusing. However, hiding the textarea element also breaks copying the input's value. Instead of hiding the textarea, we are now hiding the visiual representation of the caret. A noteable difference in behavior now is that it's possible to focus the input via tab, but there is no visual indiciation that the editor has focus (since we hide the caret, as before).
camdencheek
approved these changes
Jun 13, 2024
camdencheek
left a comment
Member
There was a problem hiding this comment.
Nice, thanks for the quick fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #49682 made some CSS changes to hide the caret as well as bracket matching for this input. I assume that seeing those in a read-only input was confusing.
However, hiding the textarea element also breaks copying the input's value. Instead of hiding the textarea, we are now hiding the visiual representation of the caret.
A noteable difference in behavior now is that it's possible to focus the input via tab, but there is no visual indiciation that the editor has focus (since we hide the caret, as before).
Test plan
Manual tested on https://sourcegraph.test:3443/site-admin/external-services/RXh0ZXJuYWxTZXJ2aWNlOjky