This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Fix Account Security page if auth provider removed#47092
Merged
Conversation
kopancek
approved these changes
Jan 30, 2023
mibali
pushed a commit
that referenced
this pull request
Jan 30, 2023
mibali
added a commit
that referenced
this pull request
Jan 31, 2023
…#47094) * Added bug fix for BB server repos * Added bug fix for BB server repos * Update CHANGELOG.md Co-authored-by: Indradhanush Gupta <indradhanush.gupta@gmail.com> * Fix Account Security page if auth provider removed (#47092) * updated the changelog * updated the changelog * updated the changelog * updated the changelog * updated the changelog --------- Co-authored-by: topebali <topebali97@gmail.com> Co-authored-by: Indradhanush Gupta <indradhanush.gupta@gmail.com> Co-authored-by: Petri-Johan Last <petri.last@sourcegraph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if an auth provider option gets removed while a user still has an account for that auth provider, the Account security page will break:
This PR adjusts this behaviour so that the resolver instead returns
nullfor the account data, and it is accordingly ignored by the page, since 1. users cannot do anything about it, and 2. it blocks them from managing their other external accounts.Test plan
Verified manually and adjusted unit test