Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

CHANGELOG: Added note on bug fix for bitbucketserver repo description#47094

Merged
mibali merged 9 commits into
mainfrom
mibali/BB-server-fix
Jan 31, 2023
Merged

CHANGELOG: Added note on bug fix for bitbucketserver repo description#47094
mibali merged 9 commits into
mainfrom
mibali/BB-server-fix

Conversation

@mibali

@mibali mibali commented Jan 30, 2023

Copy link
Copy Markdown
Contributor

Test plan

Tested locally

App preview:

Check out the client app preview documentation to learn more.

@cla-bot cla-bot Bot added the cla-signed label Jan 30, 2023
@mibali mibali changed the title Fixed a bug where the repo:has.description() parameter now shows description on Bitbucket server repos, previously it shows the repo name [#46752](https://github.com/sourcegraph/sourcegraph/pull/46752/files) Fixed a bug where the repo:has.description() parameter now shows description on Bitbucket server repos, previously it shows the repo name Jan 30, 2023
@mibali mibali requested a review from indradhanush January 30, 2023 12:22

@indradhanush indradhanush left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Requesting changes for the PR title because that goes into the commit message when being merged.

The PR title should reflect what the change is in a short sentence (60-80 chars is a good limit to aim for although it's not super strict).

So in this case something like:

CHANGELOG: Add note on bug fix for bitbucketserver repo description

Comment thread CHANGELOG.md Outdated
@mibali mibali changed the title Fixed a bug where the repo:has.description() parameter now shows description on Bitbucket server repos, previously it shows the repo name CHANGELOG: Added note on bug fix for bitbucketserver repo description Jan 30, 2023
@mibali mibali force-pushed the mibali/BB-server-fix branch from 5299f05 to 3af83ba Compare January 30, 2023 19:42

@indradhanush indradhanush left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion. Approved to unblock.

Comment thread CHANGELOG.md Outdated
- Fixed a bug where saving default Sort & Limit filters in Code Insights did not persist [#46653](https://github.com/sourcegraph/sourcegraph/pull/46653)
- Restored the old syntax for `repo:contains` filters that was previously removed in version 4.0.0. For now, both the old and new syntaxes are supported to allow for smooth upgrades. Users are encouraged to switch to the new syntax, since the old one may still be removed in a future version.
- Fixed a bug where removing an auth provider would render a user's Account Security page inaccessible if they still had an external account associated with the removed auth provider. [#47092](https://github.com/sourcegraph/sourcegraph/pull/47092)
- Fixed a bug where the `repo:has.description()` parameter now shows description on Bitbucket server repos, previously it shows the repo name [#46752](https://github.com/sourcegraph/sourcegraph/pull/46752)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed a bug where the `repo:has.description()` parameter now shows description on Bitbucket server repos, previously it shows the repo name [#46752](https://github.com/sourcegraph/sourcegraph/pull/46752)
- Fixed a bug where the `repo:has.description()` parameter now correctly shows description of a repository synced from a Bitbucket server code host connection, while previously it used to show the repository name instead [#46752](https://github.com/sourcegraph/sourcegraph/pull/46752)

@mibali mibali merged commit b2be9f3 into main Jan 31, 2023
@mibali mibali deleted the mibali/BB-server-fix branch January 31, 2023 09:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants