Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

search: add "Reindex now" to index status page#45533

Merged
stefanhengl merged 3 commits into
mainfrom
sh/add-reindex-button-2
Dec 13, 2022
Merged

search: add "Reindex now" to index status page#45533
stefanhengl merged 3 commits into
mainfrom
sh/add-reindex-button-2

Conversation

@stefanhengl

@stefanhengl stefanhengl commented Dec 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

This is my second attempt to add a new button "Reindex now" to the index status page. See #45178 for the first attempt.

Kapture 2022-12-12 at 13 25 20

Kapture 2022-12-12 at 14 23 47

What is different from #45178?

  • Use of BaseActionContainer instead of Button, hence we indicate the process states: success, failure, loading.
  • All new logic is contained in a function component

Note:

  • I didn't end up rewriting RepoSettingsIndexPage as function component, mostly because I didn't get it to work ;-).
  • The backend needs to send better error messages -> separate PR zoekt: better error messages #45534

Test plan

  • manual testing: the happy path is easily tested by just clicking "Reindex now" and inspecting the logs. For the failure case I sabotaged indexserver to cause a faulty socket connection.

App preview:

Check out the client app preview documentation to learn more.

@cla-bot cla-bot Bot added the cla-signed label Dec 12, 2022
@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Dec 12, 2022 •
edited
Loading

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.03% (+4.03 kb) 0.03% (+4.03 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 0abfb90 and 8482964 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@stefanhengl stefanhengl force-pushed the sh/add-reindex-button-2 branch from f046751 to 6afaa55 Compare December 12, 2022 13:11
@stefanhengl stefanhengl marked this pull request as ready for review December 12, 2022 13:27
limitedmage
limitedmage approved these changes Dec 12, 2022
View reviewed changes

@limitedmage limitedmage left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stefanhengl stefanhengl force-pushed the sh/add-reindex-button-2 branch from 6afaa55 to 0abfb90 Compare December 13, 2022 09:08
@stefanhengl stefanhengl merged commit 450ee1b into main Dec 13, 2022
@stefanhengl stefanhengl deleted the sh/add-reindex-button-2 branch December 13, 2022 09:31
@stefanhengl stefanhengl mentioned this pull request Dec 13, 2022
Merged
stefanhengl referenced this pull request Dec 13, 2022
@stefanhengl
CI: disable flakey test GetBulkMonikerLocations
892a5ac 
failed for https://github.com/sourcegraph/sourcegraph/pull/45533,
which is completely unrelated.
stefanhengl referenced this pull request Dec 13, 2022
@stefanhengl
CI: disable flakey test GetBulkMonikerLocations (#45608)
6098cf2 
failed for https://github.com/sourcegraph/sourcegraph/pull/45533,
which is completely unrelated.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@limitedmage limitedmage limitedmage approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stefanhengl @sg-e2e-regression-test-bob @limitedmage