This repository was archived by the owner on Sep 30, 2024. It is now read-only.
zoekt: better error messages#45534
Merged
Merged
Conversation
In case indexserver fails to serve on indexserver.sock, webserver will respond to frontend with a 502 Bad Gateway. Here we make sure to inform the user about the faulty socket connection. We also return the status code and body for all other errors.
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 158e5c1...ee9af71.
|
keegancsmith
approved these changes
Dec 12, 2022
keegancsmith
left a comment
Member
There was a problem hiding this comment.
It feels like this should be done at the zoekt layer, but this works too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case indexserver fails to serve on indexserver.sock, webserver will respond to frontend with a 502 Bad Gateway. Here we make sure to inform the user about the faulty socket connection. We also return the status code and body for all other errors.
Test plan