search: add "Reindex now" to index status page#45178
Conversation
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits e472109 and c6336cf or learn more. Open explanation
|
keegancsmith
left a comment
There was a problem hiding this comment.
LGTM from a search-core perspective. But I have no idea if the frontend code is correct, last time I touched the frontend I introduced multiple regressions with a one line change lol. So good luck :D
|
Before landing can you include a changelog entry for this? |
|
refers to #29246 |
There was a problem hiding this comment.
Is the page reload necessary? This is a very negative user experience. We only really do this on log in/log out.
There was a problem hiding this comment.
We can take it out. The goal was to refresh the data on the page after the reindex and I didn't know how to do this without a page reload. The user can trigger the reload manually.
There was a problem hiding this comment.
The page can be refreshed without a full reload by reloading the data that populates the page. Essentially re-doing the work being done in componentDidMount. If you want to do this I'm happy to help you out.
This adds a new button "Reindex now" to the index status page.
4985794 to
e472109
Compare
|
Sorry, I had to force push to solve a failing percy/Sourcegraph check |
| () => {}, | ||
| () => {} |
There was a problem hiding this comment.
Note that this will ignore any and all errors from the mutation, including network errors. We don't want to show an error message if the call fails?
This reverts commit 2f79ae3.
This adds a new button "Reindex now" to the index status page.
Relevant backend changes:
Test plan
App preview:
Check out the client app preview documentation to learn more.