This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search contexts: table view in management page#45001
Merged
Merged
Conversation
20 tasks
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits ba98770 and 1b52d29 or learn more. Open explanation
|
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 0f3cdcc...ba98770.
|
novoselrok
approved these changes
Dec 5, 2022
Base automatically changed from
jp/searchcontextsheader
to
jp/contextsstarreddefault
December 5, 2022 18:24
* search contexts: card view for mobile * fix build failure * give up on sr-only mixin
limitedmage
added a commit
that referenced
this pull request
Dec 5, 2022
* db schema and graphql schema updates * default contexts backend * query for stars * backend for settings stars and defaults * sg generate * fixes? * add foreign keys * idempotent constraints * again * search contexts: remove autodefined contexts from frontend, add to normal query (#44875) * search contexts: remove autodefined contexts from frontend, add to normal query * generate * remove real global context, use union with dummy row instead * fix some tests * fix CountSearchContexts * add test for CountSearchContexts * search contexts: order contexts list by default first, then starred, then others (#44876) * search contexts: order contexts list by default first, then starred, then others * generate mocks * Add test for new order * explicit select and remove unused scan var * simplify getting authenticated user * fix go lint * unit test for default contexts * tests for starred contexts * change graphql api to take user as param, add tests for this * update db schema to make contraints prettier * clean up db keys * search contexts: update header in list page (#44966) * search contexts: update header * add back tab * fix spacing * fix action button width * search contexts: table view in management page (#45001) * search contexts: update header * search contexts: table view in management page * add menu * fix build failure * add back tab * fix spacing * fix action button width * address minor issues from figma * search contexts: card view for mobile (#45040) * search contexts: card view for mobile * fix build failure * give up on sr-only mixin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #44903
Stacked on #44966
Implement the new table view in the contexts management page.
Menu only has the option to edit; starred and default are not implemented yet. This is still using the "show more" pagination; paged-based pagination will be implemented in a future PR.
Mobile view is also not implemented yet. I will try to send a stacked PR on this to add the mobile view before merging this.
Test plan
Verify with visual tests