This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search contexts: backend for setting as default and starring#44624
Merged
Conversation
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits d69cf06 and 1b52d29 or learn more. Open explanation
|
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 1b52d29...d69cf06.
|
novoselrok
reviewed
Nov 22, 2022
novoselrok
reviewed
Nov 22, 2022
This was referenced Nov 28, 2022
…rmal query (#44875) * search contexts: remove autodefined contexts from frontend, add to normal query * generate * remove real global context, use union with dummy row instead * fix some tests * fix CountSearchContexts * add test for CountSearchContexts * search contexts: order contexts list by default first, then starred, then others (#44876) * search contexts: order contexts list by default first, then starred, then others * generate mocks * Add test for new order * explicit select and remove unused scan var * simplify getting authenticated user * fix go lint
Contributor
Author
|
@novoselrok @camdencheek I've merged the stacked PRs #44875 and #44876 into this and added some tests, can you take a quick second look? Thanks! |
camdencheek
approved these changes
Dec 1, 2022
camdencheek
left a comment
Member
There was a problem hiding this comment.
A few comments, nothing blocking
| LEFT JOIN search_context_stars scs | ||
| ON scs.user_id = %d AND scs.search_context_id = sc.id | ||
| LEFT JOIN search_context_default scd | ||
| ON scd.user_id = %d AND scd.search_context_id = sc.id |
Member
There was a problem hiding this comment.
This turned out pretty clean!
Contributor
Author
There was a problem hiding this comment.
Yes! Thank you!! Are there still any perf implications from so many joins?
Member
There was a problem hiding this comment.
There definitely are, but these are joins on primary keys, so I'm not concerned by it. Nothing to worry about unless we see perf issues.
Contributor
Author
There was a problem hiding this comment.
Sounds great, thanks!
novoselrok
approved these changes
Dec 1, 2022
camdencheek
reviewed
Dec 1, 2022
* search contexts: update header * add back tab * fix spacing * fix action button width
* search contexts: update header * search contexts: table view in management page * add menu * fix build failure * add back tab * fix spacing * fix action button width * address minor issues from figma * search contexts: card view for mobile (#45040) * search contexts: card view for mobile * fix build failure * give up on sr-only mixin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #44903
This adds the backend code needed for allowing users to set a context as their default or starring a context. This does not yet have any changes to the behavior (eg. sort order or how default contexts will work).
Test plan
Updated existing tests to pass and made sure all the Go database tests pass with the new schema.
Not sure what other tests I should add here; this is relatively straightforward CRUD stuff. Any suggestions are appreciated.