This repository was archived by the owner on Sep 30, 2024. It is now read-only.
batches: Remote Mount #3 - HTTP API#40829
Merged
Merged
Conversation
# Conflicts: # internal/database/migration/shared/upgradedata/stitched-migration-graph.json
evict
reviewed
Sep 27, 2022
evict
approved these changes
Sep 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #31792.
Previous part: #40809
Add HTTP API endpoint to upload, retrieve, and check if files exist. Endpoints are included as part of the external services and the executor services.
Overview
The
FileHandlerhas a singleServerHTTPfunction that handlesGET(retrieval),HEAD(existence check), andPOST(upload). TheGETandHEADare nothing unique.POSTon the other hand receives amultipart/form-dataas the request.POSTalso has a security check to ensure either a site admin or the creator of the batch spec is uploading the file (not sure if this should apply to all the methods 🤔 ).POSTlimits the max size of the request to 10MB (I made this number up). In the future when not using Postgres to store the file content, this can be updated to stream the chunks (there is a comment with a link to an example repo).Follow up
Test plan
Add Go Unit Tests