This repository was archived by the owner on Sep 30, 2024. It is now read-only.
batches: Remote Mount #2 - GraphQL#40809
Merged
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff d1d3f31...d9b9bf7.
|
eseliger
reviewed
Aug 24, 2022
eseliger
left a comment
Member
There was a problem hiding this comment.
I think the diff for store stuff is duplicative in here, has it landed yet? Otherwise, maybe stack the two PRs?
Contributor
Author
|
Yea this branch is off of the first one |
eseliger
approved these changes
Aug 24, 2022
eseliger
left a comment
Member
There was a problem hiding this comment.
Approve to unblock, one question about the naming and inheritance of File2 that we might want to address.
Contributor
Author
|
@eseliger I updated the base to make the diffs easier to see and more targeted |
Member
|
Thanks! Good work splitting it up :) |
# Conflicts: # internal/database/migration/shared/upgradedata/stitched-migration-graph.json
LawnGnome
approved these changes
Sep 8, 2022
LawnGnome
left a comment
Contributor
There was a problem hiding this comment.
👍
I might have made the opposite choice on File2 inheritance, but I trust you and Erik to get this right. Definitely no further changes required.
eseliger
approved these changes
Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #31792.
Previous part: #40795
Added a GraphQL type for Batch Spec Mounts. This allows metadata to be retrieved about the files.
Note: the content of the files will be retrieved from a HTTP endpoint in a later PR.
Test plan
Add Go Unit Tests