Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

batches: Remote Mount #1 - Database#40795

Merged
Piszmog merged 40 commits into
mainfrom
rc/remote-mount-db
Sep 27, 2022
Merged

batches: Remote Mount #1 - Database#40795
Piszmog merged 40 commits into
mainfrom
rc/remote-mount-db

Conversation

@Piszmog

@Piszmog Piszmog commented Aug 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part of #31792.

First PR of a series.

This PR simply adds the migration to add the new table batch_spec_mounts. This PR also adds the store code to interact with the table.

Test plan

Added Go Unit Tests.

@cla-bot cla-bot Bot added the cla-signed label Aug 24, 2022
@Piszmog Piszmog marked this pull request as ready for review August 24, 2022 14:37
@Piszmog Piszmog requested a review from a team August 24, 2022 14:37
@Piszmog Piszmog changed the title batches: Remote Mount - Database batches: Remote Mount #1 - Database Aug 24, 2022
@sourcegraph-bot

sourcegraph-bot commented Aug 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 6d53e0c...efed245.

Notify File(s)
@eseliger enterprise/internal/batches/store/batch_spec_workspace_files.go
enterprise/internal/batches/store/batch_spec_workspace_files_test.go
enterprise/internal/batches/store/integration_test.go
enterprise/internal/batches/store/store.go
enterprise/internal/batches/types/batch_spec_workspace_file.go

eseliger
eseliger approved these changes Aug 24, 2022
View reviewed changes

@eseliger eseliger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ✨

Comment thread internal/database/schema.md Outdated
Comment thread enterprise/internal/batches/store/batch_spec_mounts.go Outdated
@Piszmog Piszmog mentioned this pull request Aug 24, 2022
Merged
LawnGnome
LawnGnome approved these changes Aug 25, 2022
View reviewed changes

@LawnGnome LawnGnome left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️

Comment thread migrations/frontend/1661441160_batch_spec_remote_mounts/up.sql
Comment thread migrations/frontend/1661441160_batch_spec_remote_mounts/up.sql Outdated
Comment thread enterprise/internal/batches/store/batch_spec_mounts.go Outdated
Comment thread enterprise/internal/batches/store/batch_spec_mounts.go Outdated
courier-new
courier-new reviewed Sep 5, 2022
View reviewed changes

@courier-new courier-new left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub is angry and not letting me add other comments to my review so I'm submitting it partially-completed to see if that helps.

Comment thread migrations/frontend/1661441160_batch_spec_remote_mounts/up.sql Outdated
courier-new
courier-new approved these changes Sep 5, 2022
View reviewed changes
Comment thread enterprise/internal/batches/store/batch_spec_mounts.go Outdated
Comment thread enterprise/internal/batches/types/batch_spec_mount.go Outdated
BolajiOlajide
BolajiOlajide approved these changes Sep 7, 2022
View reviewed changes
Comment thread enterprise/internal/batches/store/batch_spec_workspace_files.go Outdated
@Piszmog Piszmog merged commit 47fcec2 into main Sep 27, 2022
@Piszmog Piszmog deleted the rc/remote-mount-db branch September 27, 2022 13:26
sashaostrikov pushed a commit that referenced this pull request Sep 29, 2022
@Piszmog @sashaostrikov
batches: Remote Mount #1 - Database (#40795)
90e1250
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@eseliger eseliger eseliger approved these changes

@LawnGnome LawnGnome LawnGnome approved these changes

@courier-new courier-new courier-new approved these changes

@BolajiOlajide BolajiOlajide BolajiOlajide approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Piszmog @sourcegraph-bot @LawnGnome @courier-new @eseliger @BolajiOlajide