[reboot scripts] remove -t option in docker exec commands#228
Merged
yxieca merged 1 commit intosonic-net:masterfrom Mar 31, 2018
Merged
[reboot scripts] remove -t option in docker exec commands#228yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
When the command is called by ssh execution, there is no shell. With -t option these docker commands will fail. ssh execution: e.g. ssh admin@dut "sudo /usr/bin/fast-reboot"
jleveque
approved these changes
Mar 30, 2018
zhenggen-xu
added a commit
to zhenggen-xu/sonic-utilities
that referenced
this pull request
Jun 6, 2018
RB=1288101
G=lnos-reviewers
R=ntrianta,pmao,rmolina,sfardeen,zxu
* github:
[acl_loader] Support Service ACL binding to multiple services (sonic-net#236)
[show] Rename 'show session' to 'show mirror session' (sonic-net#235)
[pfcstat]: create python cli tool to show pfc counters (sonic-net#233)
[queuestat] add python CLI tool to show queue counters
[acl-loader] Not to crash upon invalid rule (sonic-net#232)
Show FDB type in fdbshow/show mac (sonic-net#231)
[show] add 'show runningconfiguration all' subcommand (sonic-net#230)
[reboot scripts] remove -t option in docker exec commands (sonic-net#228)
[reboot] reduce stop service to only stop syncd (sonic-net#223)
[crm]: Fix failures in CLI show commands (sonic-net#221)
[Fast-reboot]: Gracefully shutdown syncd in fast-reboot (sonic-net#212)
add fast-reboot support for nephos platform by stop kernel modules (sonic-net#220)
[config bgp] Convert user input ipv6 addr to lower case before comparing (sonic-net#218)
[PFCWD]: set default configuration when enabled by default (sonic-net#213)
Add fast-reboot support for Aboot based images (sonic-net#214)
sonic-utilities: Format show vlan config output (sonic-net#210)
[AAA] Support login(ascii) authentication type (sonic-net#217)
[sfputil] Adapt new way of getting PLATFORM(sonic-net#216)
[Fast-Reboot]: Adapt fast-reboot-dump script for SAIv1.2 (sonic-net#211)
Refactor fast-reboot script. Generate fast-reboot-dumps into configurable directory (sonic-net#208)
Find correct opennsl module name before stopping it (sonic-net#207)
[crm]: Add utility for CRM configuration (sonic-net#187)
[reboot] update reboot script to retrieve platform with new format (sonic-net#206)
Adapt to config engine change to load platform info properly (sonic-net#205)
[config] Add qos clear and qos reload support (sonic-net#204)
Dump default routes from APPL_DB table before fast-reboot (sonic-net#203)
[acl_loader] Fix a crash issue when appdb is not consistent with cfgdb (sonic-net#202)
[pfcwd]: add command to set pfcwd polling interval (sonic-net#192)
[acl-loader] Prevent from hanging if run by non-root user (sonic-net#199)
[config] Store ConfigDB init indicator boolean value as 1/0 in Redis to be language-agnostic (sonic-net#197)
Get Vlan Id from SAI Vlan Object if bvid present (sonic-net#196)
[TACACS+]: Fix aaa show error without configuration (sonic-net#191)
'config bgp [shutdown|startup] neighbor <hostname>' now affects all sessions for neighbor (sonic-net#195)
[sonic-clear] add a clear fdb command (sonic-net#186)
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
4dc2d0a (HEAD -> 202012, origin/202012) Clear all data from DB table when the daemon stops (sonic-net#228) 1df28d7 [ycabled] increase UT coverage of ycabled daemon (sonic-net#238) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
Co-authored-by: Prince George <prgeor@microsoft.com>
dgsudharsan
pushed a commit
to dgsudharsan/sonic-utilities
that referenced
this pull request
Nov 18, 2025
<!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "closes #xxxx", "fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related issue when the PR is merged. If you are adding/modifying/removing any command or utility script, please also make sure to add/modify/remove any unit tests from the tests directory as appropriate. If you are modifying or removing an existing 'show', 'config' or 'sonic-clear' subcommand, or you are adding a new subcommand, please make sure you also update the Command Line Reference Guide (doc/Command-Reference.md) to reflect your changes. Please provide the following information: --> #### What I did Added json support for `show platform temperature` #### How I did it #### How to verify it ``` admin@sonic:~$ show platform temperature Sensor Temperature High TH Low TH Crit High TH Crit Low TH Warning Timestamp ------------------------ ------------- --------- -------- -------------- ------------- --------- ----------------- CB_temp(0x4B) 29.5 80.0 N/A N/A N/A False 20240923 00:32:07 CPU_Core_0_temp 46.0 82.0 N/A 104.0 N/A False 20240923 00:32:07 CPU_Core_1_temp 46.0 82.0 N/A 104.0 N/A False 20240923 00:32:07 CPU_Core_2_temp 46.0 82.0 N/A 104.0 N/A False 20240923 00:32:07 CPU_Core_3_temp 45.0 82.0 N/A 104.0 N/A False 20240923 00:32:07 CPU_Package_temp 46.0 82.0 N/A 104.0 N/A False 20240923 00:32:07 FB_temp(0x4C) 35.0 80.0 N/A N/A N/A False 20240923 00:32:07 MB_FrontMAC_temp(0x49) 28.5 80.0 N/A N/A N/A False 20240923 00:32:07 MB_LeftCenter_temp(0x4A) 28.0 80.0 N/A N/A N/A False 20240923 00:32:07 MB_RearMAC_temp(0x48) 30.5 80.0 N/A N/A N/A False 20240923 00:32:07 PSU-1 temp sensor 1 N/A N/A N/A N/A N/A False 20240923 00:32:07 PSU-2 temp sensor 1 37.0 80.0 N/A N/A N/A False 20240923 00:32:07 admin@sonic:~$ show platform temperature --help Usage: show platform temperature [OPTIONS] Show device temperature information Options: --json Output in JSON format -h, -?, --help Show this message and exit. admin@sonic:~$ show platform temperature --json [ { "Sensor": "CB_temp(0x4B)", "Temperature": "29.5", "High_TH": "80.0", "Low_TH": "N/A", "Crit_High_TH": "N/A", "Crit_Low_TH": "N/A", "Warning": "False", "Timestamp": "20240923 00:32:07" }, { "Sensor": "CPU_Core_0_temp", "Temperature": "46.0", "High_TH": "82.0", "Low_TH": "N/A", "Crit_High_TH": "104.0", "Crit_Low_TH": "N/A", "Warning": "False", "Timestamp": "20240923 00:32:07" }, { "Sensor": "CPU_Core_1_temp", "Temperature": "46.0", "High_TH": "82.0", "Low_TH": "N/A", "Crit_High_TH": "104.0", "Crit_Low_TH": "N/A", "Warning": "False", "Timestamp": "20240923 00:32:07" }, { "Sensor": "CPU_Core_2_temp", "Temperature": "46.0", "High_TH": "82.0", "Low_TH": "N/A", "Crit_High_TH": "104.0", "Crit_Low_TH": "N/A", "Warning": "False", "Timestamp": "20240923 00:32:07" }, { "Sensor": "CPU_Core_3_temp", "Temperature": "45.0", "High_TH": "82.0", "Low_TH": "N/A", "Crit_High_TH": "104.0", "Crit_Low_TH": "N/A", "Warning": "False", "Timestamp": "20240923 00:32:07" }, { "Sensor": "CPU_Package_temp", "Temperature": "46.0", "High_TH": "82.0", "Low_TH": "N/A", "Crit_High_TH": "104.0", "Crit_Low_TH": "N/A", "Warning": "False", "Timestamp": "20240923 00:32:07" }, { "Sensor": "FB_temp(0x4C)", "Temperature": "35.0", "High_TH": "80.0", "Low_TH": "N/A", "Crit_High_TH": "N/A", "Crit_Low_TH": "N/A", "Warning": "False", "Timestamp": "20240923 00:32:07" }, { "Sensor": "MB_FrontMAC_temp(0x49)", "Temperature": "28.5", "High_TH": "80.0", "Low_TH": "N/A", "Crit_High_TH": "N/A", "Crit_Low_TH": "N/A", "Warning": "False", "Timestamp": "20240923 00:32:07" }, { "Sensor": "MB_LeftCenter_temp(0x4A)", "Temperature": "28.0", "High_TH": "80.0", "Low_TH": "N/A", "Crit_High_TH": "N/A", "Crit_Low_TH": "N/A", "Warning": "False", "Timestamp": "20240923 00:32:07" }, { "Sensor": "MB_RearMAC_temp(0x48)", "Temperature": "30.5", "High_TH": "80.0", "Low_TH": "N/A", "Crit_High_TH": "N/A", "Crit_Low_TH": "N/A", "Warning": "False", "Timestamp": "20240923 00:32:07" }, { "Sensor": "PSU-1 temp sensor 1", "Temperature": "N/A", "High_TH": "N/A", "Low_TH": "N/A", "Crit_High_TH": "N/A", "Crit_Low_TH": "N/A", "Warning": "False", "Timestamp": "20240923 00:32:07" }, { "Sensor": "PSU-2 temp sensor 1", "Temperature": "37.0", "High_TH": "80.0", "Low_TH": "N/A", "Crit_High_TH": "N/A", "Crit_Low_TH": "N/A", "Warning": "False", "Timestamp": "20240923 00:32:07" } ] ``` #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
When the command is called by ssh execution, there is no shell. With
-t option these docker commands will fail.
ssh execution: e.g. ssh admin@dut "sudo /usr/bin/fast-reboot"
- How to verify it
ssh admin@dut "sudo /usr/bin/fast-reboot"
ssh admin@dut "sudo /sur/bin/reboot"