[reboot] reduce stop service to only stop syncd#223
Merged
yxieca merged 1 commit intosonic-net:masterfrom Mar 29, 2018
Merged
Conversation
When the service dockers are in some rare failure situations, stopping service might get stuck. To make sure reboot always move ahead, we could request syncd to stop, wait some time, then proceed with reboot.
Contributor
Author
|
Just added 200+ reboots to the test record for this change. |
lguohan
approved these changes
Mar 29, 2018
lguohan
reviewed
Mar 29, 2018
| systemctl stop snmp | ||
| echo "Stopping syncd..." | ||
| docker exec -it syncd /usr/bin/syncd_request_shutdown --cold > /dev/null | ||
| sleep 3 |
Contributor
There was a problem hiding this comment.
does this work on Mellanox platform?
Contributor
Author
There was a problem hiding this comment.
It works on all platforms. Fast-reboot is also calling this to terminate syncd.
Regards,
Ying
zhenggen-xu
added a commit
to zhenggen-xu/sonic-utilities
that referenced
this pull request
Jun 6, 2018
RB=1288101
G=lnos-reviewers
R=ntrianta,pmao,rmolina,sfardeen,zxu
* github:
[acl_loader] Support Service ACL binding to multiple services (sonic-net#236)
[show] Rename 'show session' to 'show mirror session' (sonic-net#235)
[pfcstat]: create python cli tool to show pfc counters (sonic-net#233)
[queuestat] add python CLI tool to show queue counters
[acl-loader] Not to crash upon invalid rule (sonic-net#232)
Show FDB type in fdbshow/show mac (sonic-net#231)
[show] add 'show runningconfiguration all' subcommand (sonic-net#230)
[reboot scripts] remove -t option in docker exec commands (sonic-net#228)
[reboot] reduce stop service to only stop syncd (sonic-net#223)
[crm]: Fix failures in CLI show commands (sonic-net#221)
[Fast-reboot]: Gracefully shutdown syncd in fast-reboot (sonic-net#212)
add fast-reboot support for nephos platform by stop kernel modules (sonic-net#220)
[config bgp] Convert user input ipv6 addr to lower case before comparing (sonic-net#218)
[PFCWD]: set default configuration when enabled by default (sonic-net#213)
Add fast-reboot support for Aboot based images (sonic-net#214)
sonic-utilities: Format show vlan config output (sonic-net#210)
[AAA] Support login(ascii) authentication type (sonic-net#217)
[sfputil] Adapt new way of getting PLATFORM(sonic-net#216)
[Fast-Reboot]: Adapt fast-reboot-dump script for SAIv1.2 (sonic-net#211)
Refactor fast-reboot script. Generate fast-reboot-dumps into configurable directory (sonic-net#208)
Find correct opennsl module name before stopping it (sonic-net#207)
[crm]: Add utility for CRM configuration (sonic-net#187)
[reboot] update reboot script to retrieve platform with new format (sonic-net#206)
Adapt to config engine change to load platform info properly (sonic-net#205)
[config] Add qos clear and qos reload support (sonic-net#204)
Dump default routes from APPL_DB table before fast-reboot (sonic-net#203)
[acl_loader] Fix a crash issue when appdb is not consistent with cfgdb (sonic-net#202)
[pfcwd]: add command to set pfcwd polling interval (sonic-net#192)
[acl-loader] Prevent from hanging if run by non-root user (sonic-net#199)
[config] Store ConfigDB init indicator boolean value as 1/0 in Redis to be language-agnostic (sonic-net#197)
Get Vlan Id from SAI Vlan Object if bvid present (sonic-net#196)
[TACACS+]: Fix aaa show error without configuration (sonic-net#191)
'config bgp [shutdown|startup] neighbor <hostname>' now affects all sessions for neighbor (sonic-net#195)
[sonic-clear] add a clear fdb command (sonic-net#186)
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
…net#223) * Implement SFF-8472 * Remove duplicate cmis module monitors field * Fix TestDateField * Fix rx power and tx power scale * Add tests * Add FixedNumberRegField, enhance sff8472 tests
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Aug 9, 2025
…ermark (sonic-net#223) <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "closes #xxxx", "fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related issue when the PR is merged. If you are adding/modifying/removing any command or utility script, please also make sure to add/modify/remove any unit tests from the tests directory as appropriate. If you are modifying or removing an existing 'show', 'config' or 'sonic-clear' subcommand, or you are adding a new subcommand, please make sure you also update the Command Line Reference Guide (doc/Command-Reference.md) to reflect your changes. Please provide the following information: --> #### What I did Added json output supoort for ``` admin@sonic:~$ show queue watermark unicast --help Usage: show queue watermark unicast [OPTIONS] Show user WM for unicast queues Options: -j, --json Display1 output in JSON format [default: False] -?, -h, --help Show this message and exit. admin@sonic:~$ show queue watermark multicast --help Usage: show queue watermark multicast [OPTIONS] Show user WM for multicast queues Options: -j, --json Display1 output in JSON format [default: False] -?, -h, --help Show this message and exit. ``` #### How I did it #### How to verify it ``` admin@sonic:~$ show queue watermark multicast Egress shared pool occupancy per multicast queue: Port MC10 MC11 MC12 MC13 MC14 MC15 MC16 MC17 MC18 MC19 ----------- ------ ------ ------ ------ ------ ------ ------ ------ ------ ------ Ethernet0 0 0 0 0 0 0 0 0 0 0 Ethernet4 0 0 0 0 0 0 0 0 0 0 Ethernet8 0 0 0 0 0 0 0 0 0 0 Ethernet12 0 0 0 0 0 0 0 0 0 0 Ethernet16 0 0 0 0 0 0 0 0 0 0 Ethernet20 0 0 0 0 0 0 0 0 0 0 Ethernet24 0 0 0 0 0 0 0 0 0 0 Ethernet28 0 0 0 0 0 0 0 0 0 0 Ethernet32 0 0 0 0 0 0 0 0 0 0 Ethernet36 0 0 0 0 0 0 0 0 0 0 Ethernet40 0 0 0 0 0 0 0 0 0 0 Ethernet44 0 0 0 0 0 0 0 0 0 0 Ethernet48 0 0 0 0 0 0 0 0 0 0 Ethernet52 0 0 0 0 0 0 0 0 0 0 Ethernet56 0 0 0 0 0 0 0 0 0 0 Ethernet60 0 0 0 0 0 0 0 0 0 0 Ethernet64 0 0 0 0 0 0 0 0 0 0 Ethernet68 0 0 0 0 0 0 0 0 0 0 Ethernet72 1536 0 0 0 0 0 0 0 0 0 Ethernet76 256 0 0 0 0 0 0 0 0 0 Ethernet80 0 0 0 0 0 0 0 0 0 0 Ethernet84 0 0 0 0 0 0 0 0 0 0 Ethernet88 0 0 0 0 0 0 0 0 0 0 Ethernet92 0 0 0 0 0 0 0 0 0 0 Ethernet96 0 0 0 0 0 0 0 0 0 0 Ethernet100 0 0 0 0 0 0 0 0 0 0 Ethernet104 0 0 0 0 0 0 0 0 0 0 Ethernet108 0 0 0 0 0 0 0 0 0 0 Ethernet112 0 0 0 0 0 0 0 0 0 0 Ethernet116 0 0 0 0 0 0 0 0 0 0 Ethernet120 0 0 0 0 0 0 0 0 0 0 Ethernet124 0 0 0 0 0 0 0 0 0 0 ``` ``` admin@sonic:~$ show queue watermark multicast --json Egress shared pool occupancy per multicast queue: [ { "Port": "Ethernet0", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet4", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet8", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet12", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet16", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet20", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet24", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet28", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet32", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet36", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet40", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet44", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet48", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet52", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet56", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet60", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet64", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet68", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet72", "MC10": "1536", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet76", "MC10": "256", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet80", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet84", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet88", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet92", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet96", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet100", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet104", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet108", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet112", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet116", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet120", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" }, { "Port": "Ethernet124", "MC10": "0", "MC11": "0", "MC12": "0", "MC13": "0", "MC14": "0", "MC15": "0", "MC16": "0", "MC17": "0", "MC18": "0", "MC19": "0" } ] admin@sonic:~$ ``` #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
When the service dockers are in some rare failure situations, stopping
service might get stuck. To make sure reboot always move ahead, we
could request syncd to stop, wait some time, then proceed with reboot.
- How to verify it
I executed a few hundreds of reboots with the new script on my dut.