Skip to content

[Fanout] Update Mellanox ONYX fanout switch deploy code and templates#968

Merged
liat-grozovik merged 8 commits intosonic-net:masterfrom
keboliu:mellanox-fanout
Jun 30, 2019
Merged

[Fanout] Update Mellanox ONYX fanout switch deploy code and templates#968
liat-grozovik merged 8 commits intosonic-net:masterfrom
keboliu:mellanox-fanout

Conversation

@keboliu
Copy link
Copy Markdown
Contributor

@keboliu keboliu commented Jun 19, 2019

Description of PR

Summary:
Add Mellanox ONYX fanout switch deploy code and update the existing templates

Type of change

  • [] Bug fix
  • [] Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

Add a fanout_mlnx.yml for Mellanox ONYX fanout switch deploy
Add a fanout configuration templates for Mellanox ONYX fanout switch

ansible/roles/fanout/templates/mlnx_check_pfcwd_fanout.j2
ansible/roles/fanout/templates/mlnx_deploy_pfcwd_fanout.j2
ansible/roles/fanout/templates/mlnx_fanout.j2

How did you verify/test it?

run command on fanout swith
ansible-playbook -i lab fanout.yml -l <switch_name> -e os=mellanox --become --tags deploy -vvvv

Any platform specific information?

these change are for fanout switch which installed with Mellanox ONYX OS.

Supported testbed topology if it's a new test case?

support all topology.

Documentation

@liat-grozovik liat-grozovik merged commit 579e673 into sonic-net:master Jun 30, 2019
@keboliu keboliu deleted the mellanox-fanout branch July 3, 2019 00:46
yxieca pushed a commit that referenced this pull request Jul 10, 2019
…#968)

* fix grep ipv6 addr issue

* Add Mellanox onyx fanout switch deploy yml and template

* fix typo

* remove debug code

* revert the change to check_pfcwd_fanout.yml and deploy_pfcwd_fanout.yml

* fix typo
fraserg-arista pushed a commit to fraserg-arista/sonic-mgmt that referenced this pull request Feb 24, 2026
…c-net#968)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
PTF may see multiple default IPv6 routes coming from DUT due to RA packets. which will cause a routing issue on the PTF for
IPv6 packets as the traffic may be sent to DUT unexpectedly.

One example is that the ipv6 traffic coming in via mgmt interface, may choose one of the interfaces towards DUT to send the traffic back which is not intended.

This PR fix this routing behavior so that PTF doesn't rely on default routes learned via RA from DUT interfaces.

following is the output in PTF when RA routes are accepted on eth interfaces.
```
root@41d9f9447440:~# ip -6 route
......
default via fe80::a67a:72ff:fe55:1efc dev eth113 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth129 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth144 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth64 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth101 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth121 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth80 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth124 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth104 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth72 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth112 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth97 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth89 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth128 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth36 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth81 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth120 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth69 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth100 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth32 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth109 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth76 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth85 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth84 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth125 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth61 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth116 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth108 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth92 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth88 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth148 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth68 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth105 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth77 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth73 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth117 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth96 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth65 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth93 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
default via fe80::a67a:72ff:fe55:1efc dev eth60 proto ra metric 1024 expires 530sec mtu 9100 hoplimit 64 pref medium
root@41d9f9447440:~#
```

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
- [ ] 202511

### Approach
#### What is the motivation for this PR?
Fix mgmt routing issue for PTF container

#### How did you do it?
disable accept_ra_defrtr flag for ethxxx interfaces in PTF.

#### How did you verify/test it?
local testbed.

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…t#3112)

0ed90ba - [policerorch]: Fix return code comparison error (sonic-net#968) (1 minutes ago) <Shuotian Cheng)
80fcada -  remove crm acl_counters when acl_table removed (sonic-net#918) (3 hours ago) <JaredLius>
bd3651f - [aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (sonic-net#966) (2 minutes ago) <Shuotian Cheng>
0af226a - [aclorch]: Add MIRROR_DSCP table type (sonic-net#906) (4 weeks ago) <Shuotian Cheng>
9005962 - [vstest]: Update the mirror session state table name (sonic-net#917) (5 weeks ago) <Shuotian Cheng>
c4e3e54 - [policerorch]: Add PolicerOrch to bundle with mirror session (sonic-net#889) (6 weeks ago) <Shuotian Cheng>
ee49926 - [Makefile]: Remove header files from source files (sonic-net#883) (8 weeks ago) <Shuotian Cheng>
f889f80 - [aclorch]: Add ICMP type/code match for v4/v6 (sonic-net#868) (8 weeks ago) <Shuotian Cheng>
9931450 - [aclorch]: Add MIRRORv6 and MIRRORv4v6 support for ACL table (sonic-net#825) (9 weeks ago) <Shuotian Cheng>
a1ab18c - [mirrororch]: Fix comments typo (sonic-net#863) (9 weeks ago) <Shuotian Cheng>

sonic-swss-common
485db07 - [schema]: Add SWITCH_CAPABILITY_TABLE (sonic-net#276) (6 weeks ago) <Shuotian Cheng>        
3f49b20 - [schema]: Add POLICER configuration table (sonic-net#277) (6 weeks ago) <Shuotian Cheng>    
539b87d - [schema]: Add STATE_MIRROR_SESSION_TABLE_NAME (sonic-net#278) (6 weeks ago) <Shuotian Cheng>

sonic-utilities
dc52015 - [Sonic-utilities]: Added commands to view acl and port running configs (sonic-net#557) (6 days ago) <Prem Prakash>
635dc88 - [config]: Add config acl add/remove table command (sonic-net#541) (4 weeks ago) <Shuotian Cheng>
dcdc922 - [show]: Add show policer command (sonic-net#540) (4 weeks ago) <Shuotian Cheng>                                        
128462a - [config]: Add --policer option for mirror session (sonic-net#537) (6 weeks ago) <Shuotian Cheng>                       
38da7f3 - [acl_loader]: Add policer attribute in show mirror_session command (sonic-net#538) (6 weeks ago) <Shuotian Cheng>      
f95ff00 - [acl_loader]: Do not apply default DENY rule for MIRRORV6 table (sonic-net#522) (6 weeks ago) <Shuotian Cheng>

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
5331ecd [vslib]: Fix MACsec bug in SCI and XPN (sonic-net#1003)
ac04509 Fix build issues on gcc-10 (sonic-net#999)
1b8ce97 [pipeline] Download swss common artifact in a separated directory (sonic-net#995)
7a2e096 Change sonic-buildimage.vs artifact source from CI build to official build. (sonic-net#992)
d5866a3 [vslib]: fix create MACsec SA error (sonic-net#986)
f36f7ce Added Support for enum query capability of Nexthop Group Type. (sonic-net#989)
323b89b Support for MACsec statistics (sonic-net#892)
26a8a12 Prevent other notification event storms to keep enqueue unchecked and drained all memory that leads to crashing the switch router (sonic-net#968)
0cb253a Fix object availability conversion (sonic-net#974)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants