Skip to content

[Mellanox SimX] upstream scripts for SimX virtual testbed management#863

Closed
mykolaf wants to merge 2 commits intosonic-net:masterfrom
mykolaf:upstream_simx
Closed

[Mellanox SimX] upstream scripts for SimX virtual testbed management#863
mykolaf wants to merge 2 commits intosonic-net:masterfrom
mykolaf:upstream_simx

Conversation

@mykolaf
Copy link
Copy Markdown
Contributor

@mykolaf mykolaf commented Apr 9, 2019 •
edited
Loading

Signed-off-by: Mykola Faryma mykolaf@mellanox.com

Description of PR

Summary:
Upstream the scripts used for SimX virtual testbed management

This allows us to run t1 topology over ptf32(using only ptf docker and no VMs)

It does several things:

  • Configure the routes for t1 topology
  • Start a LLDP script on ptf docker that emulates the lldp traffic from the VMs

Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Mykola Faryma added 2 commits April 9, 2019 16:01
[Mellanox SimX] upstream scripts for SimX virtual testbed management
5c6528d 
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
add simx workaround for reboot_sonic
9f8ce8d 
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Apr 11, 2019 •
edited
Loading

it is hard to understand why we need the scripts for simx virtual testbed. Please have a description on what problem you are trying to solve. why simx virtual testbed is different from kvm virtual testbed?

@mykolaf
Copy link
Copy Markdown
Contributor Author

mykolaf commented Apr 11, 2019

@lguohan These scripts solved a problem of fast bringing up of a a testbed on limited resources.
We could make the same topology as the kvm testbed(not done yet, need time), but this is what we're using now.

@mykolaf
Copy link
Copy Markdown
Contributor Author

mykolaf commented Apr 12, 2019

@lguohan the SimX runs on CentOS, so deploying the same kvm virtual testbed is not possible without updating the scripts. To integrate it with kvm virtual testbed means more work

@liat-grozovik
Copy link
Copy Markdown
Collaborator

liat-grozovik commented Apr 15, 2019

Following earlier discussion about this approach we agreed that this can be used as initial step in order to be able to push simx on top of Mellanox ASICs and later on we can extend it to work with the EOS VMs topology. If there are no additional open issues, i would appreciate if this can be merged to be used by anyone who would like to.

@liat-grozovik
Copy link
Copy Markdown
Collaborator

liat-grozovik commented Apr 24, 2019

@maggiemsft @lguohan can you please refer to the comment and let us know if something else is missing?

@mykolaf mykolaf closed this Jul 22, 2019
@mykolaf mykolaf deleted the upstream_simx branch February 18, 2020 13:15
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@nazariig
[submodule]: Advance sonic-swss & sonic-sairedis. (sonic-net#8296)
ada56ab 
sairedis:
*[recorder] Fix incorrect attribute enum value capability query (sonic-net#843) d86b051
*[syncd] Fix fdb flood queue size limit check (sonic-net#863) 3a2af76
*[vslib] implement query for SAI_DEBUG_COUNTER_TYPE enum values (sonic-net#842) 575dcb4 

swss:
*[portsorch] fix errors when moving port from one lag to anoth… a67d8af
*[debugcounterorch] check if counter type is supported before querying… ( 04105a4
*Td2: Reclaim buffer from unused ports (sonic-net#1830) ac7f5cf
*[Dynamic Buffer Calc][202012]Bug fix: Don't create lossless buffer pr… f54b7d0 

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@stcheng
[submodules]: Backport ACL/MIRROR features to 201811 branch (sonic-ne…
b8bdeff 
…t#3112)

0ed90ba - [policerorch]: Fix return code comparison error (sonic-net#968) (1 minutes ago) <Shuotian Cheng)
80fcada -  remove crm acl_counters when acl_table removed (sonic-net#918) (3 hours ago) <JaredLius>
bd3651f - [aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (sonic-net#966) (2 minutes ago) <Shuotian Cheng>
0af226a - [aclorch]: Add MIRROR_DSCP table type (sonic-net#906) (4 weeks ago) <Shuotian Cheng>
9005962 - [vstest]: Update the mirror session state table name (sonic-net#917) (5 weeks ago) <Shuotian Cheng>
c4e3e54 - [policerorch]: Add PolicerOrch to bundle with mirror session (sonic-net#889) (6 weeks ago) <Shuotian Cheng>
ee49926 - [Makefile]: Remove header files from source files (sonic-net#883) (8 weeks ago) <Shuotian Cheng>
f889f80 - [aclorch]: Add ICMP type/code match for v4/v6 (sonic-net#868) (8 weeks ago) <Shuotian Cheng>
9931450 - [aclorch]: Add MIRRORv6 and MIRRORv4v6 support for ACL table (sonic-net#825) (9 weeks ago) <Shuotian Cheng>
a1ab18c - [mirrororch]: Fix comments typo (sonic-net#863) (9 weeks ago) <Shuotian Cheng>

sonic-swss-common
485db07 - [schema]: Add SWITCH_CAPABILITY_TABLE (sonic-net#276) (6 weeks ago) <Shuotian Cheng>        
3f49b20 - [schema]: Add POLICER configuration table (sonic-net#277) (6 weeks ago) <Shuotian Cheng>    
539b87d - [schema]: Add STATE_MIRROR_SESSION_TABLE_NAME (sonic-net#278) (6 weeks ago) <Shuotian Cheng>

sonic-utilities
dc52015 - [Sonic-utilities]: Added commands to view acl and port running configs (sonic-net#557) (6 days ago) <Prem Prakash>
635dc88 - [config]: Add config acl add/remove table command (sonic-net#541) (4 weeks ago) <Shuotian Cheng>
dcdc922 - [show]: Add show policer command (sonic-net#540) (4 weeks ago) <Shuotian Cheng>                                        
128462a - [config]: Add --policer option for mirror session (sonic-net#537) (6 weeks ago) <Shuotian Cheng>                       
38da7f3 - [acl_loader]: Add policer attribute in show mirror_session command (sonic-net#538) (6 weeks ago) <Shuotian Cheng>      
f95ff00 - [acl_loader]: Do not apply default DENY rule for MIRRORV6 table (sonic-net#522) (6 weeks ago) <Shuotian Cheng>

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@yxieca @lguohan
[201811][utilities] advance submodule heads (sonic-net#4368)
37684bb 
Submodule src/sonic-utilities f431510ae..d7e8f84cf:
Fix issue of fields overwritten before display (sonic-net#863)

Signed-off-by: Guohan Lu <lguohan@gmail.com>
Co-authored-by: Guohan Lu <lguohan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mykolaf @lguohan @liat-grozovik