Skip to content

when deploy topo:t0-16,t0-56,t0-64-32, it caused error: testbed_type is invalid#952

Closed
crzas wants to merge 1 commit intosonic-net:masterfrom
crzas:fdb
Closed

when deploy topo:t0-16,t0-56,t0-64-32, it caused error: testbed_type is invalid#952
crzas wants to merge 1 commit intosonic-net:masterfrom
crzas:fdb

Conversation

@crzas
Copy link
Copy Markdown
Contributor

@crzas crzas commented Jun 13, 2019

Description of PR

when deploy topo:t0-16,t0-56,t0-64-32, it caused error: testbed_type is invalid!
it should sync with the topologies of testcases.yml as below:
fdb:
filename: fdb.yml
topologies: [t0, t0-16, t0-56, t0-64, t0-64-32, t0-116]
required_vars:
ptf_host:
testbed_type:

Summary:
Fixes # (issue)

Type of change

  • Test case(improvement)

Approach

How did you do it?

How did you verify/test it?

we have verified it by deploying the t0-64-32 and run the fdb test case.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@crzas crzas requested a review from a team as a code owner March 2, 2022 17:37
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
* [201811][sairedis][swss] advance sub modules head

Submodule src/sonic-sairedis 18ad5f9..4c75b7f:
  > Fixed conditional operator. (sonic-net#487)

Submodule src/sonic-swss 1e99c93..cd12d48:
  > [teamsyncd]: Add information for LAG membership changes (sonic-net#982)
  > Fix vlan incremental config and add vs test cases (sonic-net#799)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* [swss] include more swss changes

Submodule src/sonic-swss cd12d48..f44029d:
  > [MirrorOrch]: Init the next hop ip with 0 instead of default constructor (sonic-net#953)
  > [AclOrch]: Fix the acl mirror counter doubled by inactive mirror and active again (sonic-net#952)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@wangxinbot
Copy link
Copy Markdown
Contributor

This PR has been open since June 2019 and appears to be abandoned. The FDB tests have been migrated to the pytest framework (see tests/fdb/), and ansible/roles/test/tasks/fdb.yml is legacy code.

The fix also introduces a bug — the topology names are unquoted in the YAML list, so Ansible/Jinja2 would treat t0, t0-16, etc. as variable references instead of string literals. The original code correctly used quoted strings ('t0', 't0-64', etc.).

Suggest closing this PR.

@wangxin
Copy link
Copy Markdown
Collaborator

wangxin commented Mar 27, 2026

Closing this PR.

@wangxin wangxin closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants