[bgp] Fix test_bgp_update_timer#3189
Merged
lolyu merged 1 commit intosonic-net:masterfrom Mar 24, 2021
Merged
Conversation
`FRR` checks if a new neighbor is a already-defined neighbor within the dynamic range. And `BGPNeighbor.start_session` always starts `exa_bgp` then pushs the neighbor definitions to config_db. For t0 testbeds, the neighbor is within subnet `192.168.0.0/21` that occurs to be same as the one used by `BGPVac`. So after `BGPNeighbor.start_session` starts `exa_bgp`, `FRR` will detects the new connections as `BGPVac`, so subsequent neighbor will make `FRR` complain. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
bingwang-ms
approved these changes
Mar 23, 2021
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
What is the motivation for this PR? `FRR` checks if a new neighbor is a already-defined neighbor within the dynamic range. And `BGPNeighbor.start_session` always starts `exa_bgp` then pushs the neighbor definitions to config_db. For t0 testbeds, the neighbor is within subnet `192.168.0.0/21` that occurs to be same as the one used by `BGPVac`. So after `BGPNeighbor.start_session` starts `exa_bgp`, `FRR` will detects the new connections as `BGPVac`, so subsequent neighbor will make `FRR` complain. As issue sonic-net#3188 How did you do it? Starts exa_bgp session after pushing neighbor definitions. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…atically (sonic-net#18331) #### Why I did it src/sonic-utilities ``` * c0ba32ad - (HEAD -> 202305, origin/202305) CLI to skip polling for periodic information for a port in DomInfoUpdateTask thread (sonic-net#3187) (16 hours ago) [mihirpat1] * 261cfdf7 - CLI enhancements to revtrieve data from TRANSCEIVER_FIRMWARE_INFO table (sonic-net#3177) (sonic-net#3189) (19 hours ago) [mssonicbld] * 6160ee79 - [202305][config] Add YANG alerting for override (sonic-net#3195) (20 hours ago) [jingwenxie] * a55624d8 - [fast/warm-reboot] Put ERR message in syslog when a failure is seen (sonic-net#3186) (34 hours ago) [Vaibhav Hemant Dixit] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
FRRchecks if a new neighbor is a already-defined neighbor within thedynamic range. And
BGPNeighbor.start_sessionalways startsexa_bgpthen pushs the neighbor definitions to config_db. For t0 testbeds, the
neighbor is within subnet
192.168.0.0/21that occurs to be same as theone used by
BGPVac. So afterBGPNeighbor.start_sessionstartsexa_bgp,FRRwill detects the new connections asBGPVac, sosubsequent neighbor will make
FRRcomplain.Signed-off-by: Longxiang Lyu lolv@microsoft.com
Summary:
Fixes #3188
Type of change
Approach
What is the motivation for this PR?
As issue #3188
How did you do it?
Starts
exa_bgpsession after pushing neighbor definitions.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation