Enhanced test case "show platform ssdhealth" to do validation for values in the output#8457
Closed
ppikh wants to merge 4 commits intosonic-net:masterfrom
Closed
Enhanced test case "show platform ssdhealth" to do validation for values in the output#8457ppikh wants to merge 4 commits intosonic-net:masterfrom
ppikh wants to merge 4 commits intosonic-net:masterfrom
Conversation
…ues in the output Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C Signed-off-by: Petro Pikh <petrop@nvidia.com>
AntonHryshchuk
previously approved these changes
May 30, 2023
roy-sror
reviewed
May 30, 2023
…ues in the output Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C Signed-off-by: Petro Pikh <petrop@nvidia.com>
…kh/sonic-mgmt into improved_ssd_test_validation
roy-sror
approved these changes
May 31, 2023
Collaborator
|
@ppikh the description has no reference to Bluefield although there are some changes. |
Contributor
Author
|
Hi @liat-grozovik |
Collaborator
|
@prgeor could you please review/approve? |
Collaborator
|
@prgeor kindly reminder to provide your feedback |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azpw run |
Collaborator
|
Only PR owner can use /azpw run |
11 tasks
Contributor
11 tasks
mssonicbld
added a commit
to mssonicbld/sonic-mgmt.msft
that referenced
this pull request
Aug 19, 2025
…ues in output This PR duplicates sonic-net/sonic-mgmt#8457 <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Enhanced test case "show platform ssdhealth" to do validation for values in the output Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C Added support to get the path to SSD based on platform type. Added support to define sensors that have "N/A" value per platform. Summary: Enhanced test case "show platform ssdhealth" to do validation for values in the output Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? Enhanced test case "show platform ssdhealth" to do validation for values in the output #### How did you do it? Added validation for values in output #### How did you verify/test it? Executed test on different platforms #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
11 tasks
mssonicbld
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Aug 19, 2025
…o validation for values in output (#659) This PR duplicates sonic-net/sonic-mgmt#8457 <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Enhanced test case "show platform ssdhealth" to do validation for values in the output Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C Added support to get the path to SSD based on platform type. Added support to define sensors that have "N/A" value per platform. Summary: Enhanced test case "show platform ssdhealth" to do validation for values in the output Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? Enhanced test case "show platform ssdhealth" to do validation for values in the output #### How did you do it? Added validation for values in output #### How did you verify/test it? Executed test on different platforms #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Enhanced test case "show platform ssdhealth" to do validation for values in the output
Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C
Added support to get the path to SSD based on platform type.
Added support to define sensors that have "N/A" value per platform.
Summary: Enhanced test case "show platform ssdhealth" to do validation for values in the output
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Enhanced test case "show platform ssdhealth" to do validation for values in the output
How did you do it?
Added validation for values in output
How did you verify/test it?
Executed test on different platforms
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation