Enhanced test case "show platform ssdhealth" to do validation for values in output#18907
Merged
roy-sror merged 1 commit intosonic-net:masterfrom Aug 18, 2025
Merged
Conversation
…ues in output Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks that values detected(not "N/A"), does check that SSD health is bigger than 50% and checks that temperature is less than 100C
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
6 tasks
nhe-NV
approved these changes
Jun 13, 2025
Contributor
|
@bingwang-ms can you help to review and merge? Thanks! |
Contributor
|
@prgeor - your approval pls |
Contributor
|
@judyjoseph can you review |
Contributor
|
@judyjoseph can you help to review? |
Contributor
|
@judyjoseph - can you pls review? |
roy-sror
approved these changes
Aug 18, 2025
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 19, 2025
…ues in output (sonic-net#18907) Enhanced test case "show platform ssdhealth" to do validation for values in the output Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C Added support to get the path to SSD based on platform type. Added support to define sensors that have "N/A" value per platform. Summary: Enhanced test case "show platform ssdhealth" to do validation for values in the output
Collaborator
|
Cherry-pick PR to 202505: #20319 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 19, 2025
…ues in output (#18907) Enhanced test case "show platform ssdhealth" to do validation for values in the output Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C Added support to get the path to SSD based on platform type. Added support to define sensors that have "N/A" value per platform. Summary: Enhanced test case "show platform ssdhealth" to do validation for values in the output
11 tasks
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#659 |
nikamirrr
pushed a commit
to nikamirrr/nmirin-sonic-mgmt
that referenced
this pull request
Aug 20, 2025
…ues in output (sonic-net#18907) Enhanced test case "show platform ssdhealth" to do validation for values in the output Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C Added support to get the path to SSD based on platform type. Added support to define sensors that have "N/A" value per platform. Summary: Enhanced test case "show platform ssdhealth" to do validation for values in the output
echuawu
pushed a commit
to echuawu/sonic-mgmt
that referenced
this pull request
Aug 25, 2025
…ues in output (sonic-net#18907) Enhanced test case "show platform ssdhealth" to do validation for values in the output Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C Added support to get the path to SSD based on platform type. Added support to define sensors that have "N/A" value per platform. Summary: Enhanced test case "show platform ssdhealth" to do validation for values in the output
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
…ues in output (sonic-net#18907) Enhanced test case "show platform ssdhealth" to do validation for values in the output Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C Added support to get the path to SSD based on platform type. Added support to define sensors that have "N/A" value per platform. Summary: Enhanced test case "show platform ssdhealth" to do validation for values in the output
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…ues in output (sonic-net#18907) Enhanced test case "show platform ssdhealth" to do validation for values in the output Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C Added support to get the path to SSD based on platform type. Added support to define sensors that have "N/A" value per platform. Summary: Enhanced test case "show platform ssdhealth" to do validation for values in the output Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…ues in output (sonic-net#18907) Enhanced test case "show platform ssdhealth" to do validation for values in the output Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C Added support to get the path to SSD based on platform type. Added support to define sensors that have "N/A" value per platform. Summary: Enhanced test case "show platform ssdhealth" to do validation for values in the output Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…ues in output (sonic-net#18907) Enhanced test case "show platform ssdhealth" to do validation for values in the output Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C Added support to get the path to SSD based on platform type. Added support to define sensors that have "N/A" value per platform. Summary: Enhanced test case "show platform ssdhealth" to do validation for values in the output Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…ues in output (sonic-net#18907) Enhanced test case "show platform ssdhealth" to do validation for values in the output Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C Added support to get the path to SSD based on platform type. Added support to define sensors that have "N/A" value per platform. Summary: Enhanced test case "show platform ssdhealth" to do validation for values in the output Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…ues in output (sonic-net#18907) Enhanced test case "show platform ssdhealth" to do validation for values in the output Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C Added support to get the path to SSD based on platform type. Added support to define sensors that have "N/A" value per platform. Summary: Enhanced test case "show platform ssdhealth" to do validation for values in the output
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…ues in output (sonic-net#18907) Enhanced test case "show platform ssdhealth" to do validation for values in the output Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C Added support to get the path to SSD based on platform type. Added support to define sensors that have "N/A" value per platform. Summary: Enhanced test case "show platform ssdhealth" to do validation for values in the output Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…ues in output (sonic-net#18907) Enhanced test case "show platform ssdhealth" to do validation for values in the output Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C Added support to get the path to SSD based on platform type. Added support to define sensors that have "N/A" value per platform. Summary: Enhanced test case "show platform ssdhealth" to do validation for values in the output Signed-off-by: Yael Tzur <ytzur@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…ues in output (sonic-net#18907) Enhanced test case "show platform ssdhealth" to do validation for values in the output Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C Added support to get the path to SSD based on platform type. Added support to define sensors that have "N/A" value per platform. Summary: Enhanced test case "show platform ssdhealth" to do validation for values in the output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR duplicates #8457
Description of PR
Enhanced test case "show platform ssdhealth" to do validation for values in the output
Originally test did just check for keys: "Device Mode", "Health", "Temperature" - now it also checks the values detected(not "N/A"), does check that SSD health is bigger than 50%, and checks that temperature is less than 100C
Added support to get the path to SSD based on platform type.
Added support to define sensors that have "N/A" value per platform.
Summary: Enhanced test case "show platform ssdhealth" to do validation for values in the output
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Enhanced test case "show platform ssdhealth" to do validation for values in the output
How did you do it?
Added validation for values in output
How did you verify/test it?
Executed test on different platforms
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation