[arp] Replace ifconfig cmd with config interface command#783
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jan 18, 2019
wangxin:arp
Merged
[arp] Replace ifconfig cmd with config interface command#783lguohan merged 1 commit intosonic-net:masterfrom wangxin:arp
lguohan merged 1 commit intosonic-net:masterfrom
wangxin:arp
Conversation
If use ifconfig to configure IP address or startup interface, the unicast ARP reply case may fail. Possibly interface was not in proper state and failed to reply. Signed-off-by: Xin Wang <xinw@mellanox.com>
jleveque
approved these changes
Jan 18, 2019
Collaborator
|
Made to 201811 branch on 1/18/2019 |
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 3, 2026
…OFF pause frames (sonic-net#783) ### Description of PR This PR adds a new test under tests/counter/ to verify that receiving IEEE 802.3x pause frames (XON/XOFF) does not incorrectly increment RX_DROP counters on the DUT Summary: Fixes sonic-net#20499 ### Type of change - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Approach #### What is the motivation for this PR? The motivation is to address [Issue sonic-net#20499](https://github.com/sonic-net/sonic-mgmt/issues/20499?utm_source=chatgpt.com) #### How did you do it? I implemented a new test test_xon_xoff_does_not_increase_rx_drop under tests/counter/. The test selects a random operational DUT port. It maps the DUT port to a PTF port index using tbinfo['topo']['ptf_map']. It crafts valid IEEE 802.3x PAUSE frames (both XOFF with pause_time > 0 and XON with pause_time == 0). Frames are transmitted from the PTF host towards the DUT. RX_DROP counters are read before and after transmission using sonic-db-cli or redis-cli. The test asserts that RX_DROP does not increase. #### Any platform specific information? No platform-specific dependencies. #### Supported testbed topology if it's a new test case? The test supports topologies t0 and t1
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Change in this updat:
b39e746 Spell check fixes (sonic-net#783)
373be80 [build-vm] Don't Install Lib Boost 1.67 (sonic-net#784)
signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…nch (sonic-net#2526) * [submodule 201811] advance sairedis and swss submodule for 201811 branch Submodule src/sonic-sairedis 60f97c3..bdb0074: > Add more information on failed map sizes (sonic-net#416) > Add WRED specific comparison logic (sonic-net#413) > Initialize notification queue pointer before switch create (sonic-net#411) > Add log info for not matching SG/IPG/QUEUES (sonic-net#409) > Add support for any number of ports in virtual switch using lane map (sonic-net#407) Submodule src/sonic-swss 85f6322..65a0256: > Increase the watermark polling interval to 10s (sonic-net#777) > [vstest]: fix test_port_an_warm.py test (sonic-net#779) > [wartermarkorch] Fix repeated m_pg_ids and m_unicast_queue_ids add up issue (sonic-net#752) > [teammgrd] Fix inconsistent port admin status (sonic-net#755) > Remove AclTableGroup upon removal of port/lag/vlan (sonic-net#751) Signed-off-by: Ying Xie <ying.xie@microsoft.com> * [submodule] advance sonic-swss submodule Submodule src/sonic-swss 65a0256..bf21ee3: > On a routing vlan, the neighbor entry in the /31 subnet is not added … (sonic-net#784) > portsorch ports init done flag should means buffer, autoneg, speed, m… (sonic-net#747) (sonic-net#783) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If use ifconfig to configure IP address or startup interface,
the unicast ARP reply case may fail. Possibly interface was not in
proper state and failed to reply.
Signed-off-by: Xin Wang xinw@mellanox.com
Description of PR
Summary:
Fixes # (issue)
The arp testcase failed ocassionally. Command
ifconfigis used to startup and configure IP address for interfaces. The formal way is to use theconfig interfacecommand. Possibly interface was not in proper status if it is configured byifconfig.This change replace the
ifconfigcommand with more formalconfig interface.Type of change
Approach
How did you do it?
Changed
ifconfigto more formalconfig interfacefor startup and configuring interfaces.How did you verify/test it?
Run the script on Mellanox switches and the script passed.
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
Documentation