[reboot_sonic] Fix reboot task#779
Merged
yxieca merged 1 commit intosonic-net:masterfrom Jan 23, 2019
Merged
Conversation
Increase async task timeout since reboot may take more than 1 sec Poll reboot task status untill reboot fails or DUT connection fails If reboot failed ansible will fail with error message extracted from reboot Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
b16bb16 to
fe0cd0e
Compare
yxieca
approved these changes
Jan 23, 2019
Collaborator
|
Made to 201811 branch on 1/25/2019 |
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Oct 27, 2025
… docker-sonic-mgmt (sonic-net#779) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? To support docker-sonic-mgmt based on Ubuntu 24.04, the setup-container.sh needs some minor improvements: #### How did you do it? 1. The Ubuntu 24.04 docker image as account "ubuntu" by default. Its uid could conflict with the user's uid. This change added code to best effort deleting this default "ubuntu" account. 2. In old docker-sonic-mgmt, python3 is installed in virtual environment. In 2024, the docker-sonic-mgmt was updated to install python3 in global environment. It's no longer necessary to hack the virtual environment. This change adjusted the sequence of conditions for hacking venv, so that the code can fail faster to skip this step. In the future, this piece of code should can be deleted. #### How did you verify/test it? Use the updated script to setup sonic-mgmt container use both old and new docker-sonic-mgmt images. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…ing shutdown (sonic-net#6581) Remove unregisterMessageHandler from NetMsgRegistrar thread (sonic-net#779)
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…nch (sonic-net#2526) * [submodule 201811] advance sairedis and swss submodule for 201811 branch Submodule src/sonic-sairedis 60f97c3..bdb0074: > Add more information on failed map sizes (sonic-net#416) > Add WRED specific comparison logic (sonic-net#413) > Initialize notification queue pointer before switch create (sonic-net#411) > Add log info for not matching SG/IPG/QUEUES (sonic-net#409) > Add support for any number of ports in virtual switch using lane map (sonic-net#407) Submodule src/sonic-swss 85f6322..65a0256: > Increase the watermark polling interval to 10s (sonic-net#777) > [vstest]: fix test_port_an_warm.py test (sonic-net#779) > [wartermarkorch] Fix repeated m_pg_ids and m_unicast_queue_ids add up issue (sonic-net#752) > [teammgrd] Fix inconsistent port admin status (sonic-net#755) > Remove AclTableGroup upon removal of port/lag/vlan (sonic-net#751) Signed-off-by: Ying Xie <ying.xie@microsoft.com> * [submodule] advance sonic-swss submodule Submodule src/sonic-swss 65a0256..bf21ee3: > On a routing vlan, the neighbor entry in the /31 subnet is not added … (sonic-net#784) > portsorch ports init done flag should means buffer, autoneg, speed, m… (sonic-net#747) (sonic-net#783) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase async task timeout since reboot may take more than 1 sec
Wait for SSH to shutdown, if timeout exceed poll reboot task status
If reboot failed ansible will fail with error message extracted from reboot
Signed-off-by: Stepan Blyschak stepanb@mellanox.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation