Skip to content

Make cavium containers share the domain socket directory of redis-server#76

Merged
lguohan merged 1 commit intosonic-net:masterfrom
NStetskovych-zz:share_redis
Jan 5, 2017
Merged

Make cavium containers share the domain socket directory of redis-server#76
lguohan merged 1 commit intosonic-net:masterfrom
NStetskovych-zz:share_redis

Conversation

@NStetskovych-zz
Copy link
Copy Markdown

Signed-off-by: Nadiya.Stetskovych Nadiya.Stetskovych@cavium.com

Signed-off-by: Nadiya.Stetskovych <Nadiya.Stetskovych@cavium.com>
@lguohan lguohan merged commit f0d57e5 into sonic-net:master Jan 5, 2017
@NStetskovych-zz NStetskovych-zz deleted the share_redis branch January 5, 2017 19:25
StormLiangMS pushed a commit to StormLiangMS/sonic-mgmt that referenced this pull request Dec 16, 2023
…ansible is upgraded

Fix fanout unreachable issue after ansible is upgraded

We recently upgraded the Ansible version to 6.7.0 in the sonic-mgmt docker image.
If run tests using python3 and the latest sonic-mgmt docker, creating the
fanouthosts fixture will fail with a “Host Unreachable” error if the fanout
switch is running SONiC.

The reason for this is that we supplied both “ansible_ssh_pass” and
“ansible_ssh_password” variables while initializing the SONiC fanouthosts fixture.

After the Ansible version was upgraded, the order of using the variables might
have changed, and an inconsistent value of this variable caused an authentication
issue, which eventually resulted in the “Host Unreachable” error.

Fanout hosts are defined under the “fanout” group in the inventory file.
The group vars file ansible/fanout/secrets.yml defines “ansible_ssh_password” as
follows:

    ansible_ssh_password: “{{ secret_group_vars[‘fanout’][‘ansible_ssh_pass’] }}”

Based on the current secrets.json, “ansible_ssh_password” is rendered to “fanoutpassword”.

While initializing SONiC fanouthosts, line sonic-net#76 in tests/common/devices/sonic.py tries to
initialize the variable “ansible_ssh_pass” to the current value “password”.

Now we have both:
    ansible_ssh_password: “fanoutpassword”
    ansible_ssh_pass: “password”

With the older Ansible version, “ansible_ssh_pass” is used, and it works for SONiC-based
fanout switches. With the latest Ansible version, “ansible_ssh_password” is used and
results in an authentication failure.

The fix is to update the variable name in “fanout/secrets.yml” to “ansible_ssh_pass”.

Signed-off-by: Xin Wang <xiwang5@microsoft.com>
nhe-NV pushed a commit to nhe-NV/sonic-mgmt that referenced this pull request May 12, 2025
Align acl test for t0-isolated-d16u16s1, in this t0 topo, there is no portchannel, need to update the test case to get the correct upstream port.

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
Fixes # (issue)

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [x] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [x] 202412

### Approach
#### What is the motivation for this PR?

#### How did you do it?

#### How did you verify/test it?

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
1c3f75e (HEAD -> master, origin/master, origin/HEAD) pindown the version of github.com/openconfig/gnoi (sonic-net#76)
33acd5b [ci]: setup proper azp (sonic-net#75)
5d82051 [CI] Set up CI with Azure Pipelines (sonic-net#72)
0688cdb Remove go get commands from Makefile to prevent go.mod file from chan… (sonic-net#66)
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
[202012][sonic-linkmgrd] Submodule Update

d3f5de1 Jing Zhang Tue Aug 9 10:14:48 2022 -0700 Fix build failure introduced by commit 847c1e8 (sonic-net#105)
847c1e8 Jing Zhang Mon Aug 8 10:36:18 2022 -0700 [Active-Standby]Remove unnecessary handleMuxWaitTimeout logs (sonic-net#100)
1fdf0e6 Jing Zhang Thu Jul 21 10:33:45 2022 -0700 Add support for reconciliation after warm restart (sonic-net#76) (sonic-net#97)

sign-off: Jing Zhang zhangjing@microsoft.com
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
… advance submodule head (sonic-net#11518)

sairedis:
* 38c0bb1 2022-07-21 | [sairedis] Fix reopen recoding file (sonic-net#1087) (HEAD -> 202205, github/202205) [Kamil Cudnik]

platform-daemon:
* 17587b6 2022-07-22 | [ycabled] add secure channel support for grpc dualtor active-active connectivity  (sonic-net#275) (HEAD -> 202205, github/202205) [vdahiya12]

linkmgrd:
* c911ec7 2022-07-21 | Avoid unnecessary error logs from `handleGetServerMacAddressNotification` (sonic-net#96) (HEAD -> 202205) [Jing Zhang]
* bbae81d 2022-07-18 | Add support for reconciliation after warm restart  (sonic-net#76) [Jing Zhang]

utilities:
* bcc1206 2022-07-20 | Change db_migrator major version on master branch from version 2 to 3 (sonic-net#2272) (HEAD -> 202205) [Vaibhav Hemant Dixit]
* ad40697 2022-07-21 | Fix test for pfcwd_sw_enable in db_migrator_test (sonic-net#2253) [bingwang-ms]
* 886f612 2022-07-22 | Revert "show commands for SYSTEM READY (sonic-net#1851) (sonic-net#2261)" (sonic-net#2274) (github/202205) [Ying Xie]
* a6404b7 2022-07-17 | show commands for SYSTEM READY (sonic-net#1851) (sonic-net#2261) [Senthil Kumar Guruswamy]

swss-common:
* 509b265 2022-07-06 | Add device global table definition (sonic-net#645) (HEAD -> 202205) [tjchadaga]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants