Merged
Conversation
Signed-off-by: Nadiya.Stetskovych <Nadiya.Stetskovych@cavium.com>
stcheng
reviewed
Jan 5, 2017
| ExecStopPost=/usr/bin/mst stop | ||
| {% elif sonic_hwsku == 'AS7512' %} | ||
| ExecStopPost=/etc/init.d/xpnet.sh stop | ||
| ExecStopPost=/etc/init.d/xpnet.sh start |
Contributor
There was a problem hiding this comment.
why xpnet.sh will be started after the docker syncd stops?
Author
There was a problem hiding this comment.
@stcheng for example for ptf testing (when syncd stopped and saiserver deployed)
Contributor
There was a problem hiding this comment.
I see. then i'm just wondering if this logic is better embedded to the saiserver or somewhere else. thanks for answering my question.
8 tasks
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Feb 21, 2025
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Add a module-level fixture for temporarily disabling route check for a test module Summary: Fixes # (issue) Microsoft ADO 31326413 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [x] 202411 ### Approach #### What is the motivation for this PR? In our recent Cisco T2 Nightly run, we observed that we would get the following error syslog during some test modules: ``` E Failed: Processes "['analyze_logs--<MultiAsicSonicHost dut-lc1-1>']" failed with exit code "1" E Exception: E match: 1 E expected_match: 0 E expected_missing_match: 0 E E Match Messages: E 2025 Feb 3 03:03:29.550827 svcstr2-8800-lc1-1 ERR monit[914]: 'routeCheck' status failed (255) -- Failure results: {{sonic-net#12 "asic1": {sonic-net#12 "Unaccounted_ROUTE_ENTRY_TABLE_entries": [sonic-net#12 "100.1.0.22/32",sonic-net#12 ``` After discussion, we decided to add a fixture so users can disable route check for a test module if they think that test tends to have such error syslog. #### How did you do it? #### How did you verify/test it? I ran the updated code and can confirm it's working well. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Feb 17 Fix tests failing due to duplicate vxlan tunnel creation (sonic-net#75) Mar 11 Update route api to specify limitation (sonic-net#77) Apr 01 Add host_ifname field while adding entry in VLAN table (sonic-net#80)
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
1c3f75e (HEAD -> master, origin/master, origin/HEAD) pindown the version of github.com/openconfig/gnoi (sonic-net#76) 33acd5b [ci]: setup proper azp (sonic-net#75) 5d82051 [CI] Set up CI with Azure Pipelines (sonic-net#72) 0688cdb Remove go get commands from Makefile to prevent go.mod file from chan… (sonic-net#66)
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…atically (sonic-net#15373) src/sonic-telemetry * 5a83c07 - (HEAD -> 202205, origin/202205) Merge pull request sonic-net#109 from zbud-msft/backport-202205 (86 minutes ago) [Ying Xie] * 0f75a64 - [202012] Workaround gomonkey for armhf (sonic-net#88) (3 weeks ago) [Zain Budhwani] * 1b0dc75 - Fix Makefile error (3 weeks ago) [Zain Budhwani] * 72e4540 - Add diff cov (sonic-net#85) (3 weeks ago) [Zain Budhwani] * 11aace5 - Add get-update to azp yml (sonic-net#79) (3 weeks ago) [Zain Budhwani] * 3eaaccc - Add net core and code coverage results (sonic-net#77) (3 weeks ago) [Zain Budhwani] * 3cf3883 - Enable unit test (3 weeks ago) [ganglyu] * 2a0928f - Change dir name in pipeline (sonic-net#75) (4 weeks ago) [Zain Budhwani] * baa845a - Update yml (4 weeks ago) [Zain Budhwani] * c533d52 - Fix format (4 weeks ago) [ganglyu]
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Feb 17 Fix tests failing due to duplicate vxlan tunnel creation (sonic-net#75) Mar 11 Update route api to specify limitation (sonic-net#77) Apr 01 Add host_ifname field while adding entry in VLAN table (sonic-net#80)
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…utomatically (sonic-net#17229) #### Why I did it src/sonic-host-services ``` * 689395a - (HEAD -> 202305, origin/202305) Updated the iptable rule to use parent/base name of midplane interface of chassis. (sonic-net#75) (2 days ago) [abdosi] * 45212a8 - [DualToR][caclmgrd] Fix IPtables rules for multiple vlan interfaces for DualToR config (sonic-net#82) (2 days ago) [vdahiya12] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nadiya.Stetskovych Nadiya.Stetskovych@cavium.com